From 86b4d24c9ac7cf94a62ad8e88cbb62282774a80d Mon Sep 17 00:00:00 2001 From: janakelarsson Date: Wed, 2 Dec 2020 06:16:52 +0100 Subject: [PATCH] No SMS deadlock (#52) * Prevent deadlock on sms send/receive * Use NB_SMS.ready() * Whitespace * Typo * Code style --- src/NB_SMS.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/NB_SMS.cpp b/src/NB_SMS.cpp index 20c2025..6fce180 100644 --- a/src/NB_SMS.cpp +++ b/src/NB_SMS.cpp @@ -96,9 +96,7 @@ int NB_SMS::endSMS() MODEM.write(26); if (_synch) { - while ((r = MODEM.ready()) == 0) { - delay(100); - } + r = MODEM.waitForResponse(3*60*1000); } else { r = MODEM.ready(); } @@ -129,7 +127,8 @@ int NB_SMS::available() } if (_synch) { - while ((r = ready()) == 0) { + unsigned long start = millis(); + while ((r = ready()) == 0 && (millis() - start) < 3*60*1000) { delay(100); } } else {