Stitching schema with multiple endpoints same returning type is not working

[alexandra-c]

Hello,

I'm trying to stitch multiple schemas and one of them defines 2 endpoints that return the same type:
Partner service:

type MasterPartner {
  id: Int!
  partnerTypeId: Int
  uniqueId: String
  ...
}

extend type Query {
  masterPartnerbyKey(uniqueId: String!, partnerTypeId: Int!): MasterPartner!
  masterPartnerById(id: Int): MasterPartner! 
}

Insurance service:

type Partner {
  id: Int!
  partnerTypeId: Int!
  uniqueId: String
  masterPartner: MasterPartner
  ...
}

type MasterPartner {
  uniqueId: String
  partnerTypeId: Int
}

extend type Query {
  partner(id: Int!): Partner!
}

Origination service:

type Partner {
  id: Int!
  partnerTypeId: Int!
  uniqueId: String
  dealerId: Int!
  masterPartner: MasterPartner
  ...
}

type MasterPartner {
  id: Int
}

extend type Query {
  partner(id: Int!): Partner!
}

I tried to do what the doc says here: https://www.graphql-tools.com/docs/stitch-type-merging/#multiple-keys or here https://github.com/gmac/schema-stitching-handbook/tree/master/type-merging-multiple-keys#multiple-entrypoints

const { stitchingDirectivesTransformer } = stitchingDirectives();

const gatewaySchema = stitchSchemas({
  subschemaConfigTransforms: [stitchingDirectivesTransformer],
  subschemas: [
    { schema: insuranceSchema },
    { schema: originationSchema },
    {
      schema: partnerSchema,
      batch: true,
      merge: {
        MasterPartner: {
          entryPoints: [
            {
              selectionSet: '{ uniqueId partnerTypeId }',
              fieldName: 'masterPartnerByKey',
              // args: (uniqueId, partnerTypeId) => ({ uniqueId, partnerTypeId })
              key: ({ uniqueId, partnerTypeId }) => ({ uniqueId, partnerTypeId }),
              argsFromKeys: keys => ({ keys })
            },
            {
              selectionSet: '{ id }',
              fieldName: 'masterPartnerById',
              // args: id => ({ id }),
              key: ({ id }) => ({ id }),
              argsFromKeys: keys => ({ keys })
            }
          ]
        }
      }
    }
  ]
});

but i can't make it work....

When executing the following query it does not load the masterPartner info...and the Partner service is not called at all...

query partners {
  insurance_partner(id: 77) {
    id
    masterPartner {
      id
      uniqueId
      partnerTypeId
      partnerName
    }
  }
  origination_partner(id: 8621) {
    id
    masterPartner {
      id
      uniqueId
      partnerTypeId
      partnerName
    }
  }
}

What am i doing wrong? 🤔

Not sure if this is related to #2515

[yaacovCR]

You are using key and argsFromKeys but you are not delegating to a list, I think you need to just use args, which you have commented out. Is that not working either?

In this example, you shouldn’t need multiple entry points, as you have the id so you can just use masterPartnerById

you need merge config for the insurance schema, which is tricky as seems like the type is nested in this schema. You may need to use a transform. Some sample data may help me understand

[yaacovCR]

Multiple entry points work, you can start with tests from associated PR and work from there. The idea is you might get some data from some subschema that has one type of key A and another from a different subschema with key B, and you can enter schema C with either one. In this scenario, each entry point would have a different root field, different selectionSet key, etc.

[yaacovCR]

From my brief scan looks like you have set up right, but can’t really dig in until next week

[alexandra-c]

I followed @gmac 's example, i probably missed something but i can't figure out what.

From my brief scan looks like you have set up right, but can’t really dig in until next week

It's ok, it can wait until next week, no problem. Thank you for helping me😁

[gmac]

Can you start from the working example in the schema stitching handbook and evolve it to match your case, watching where it breaks down? I’m onboarding at a new job right now and very busy. My advice is always to start from something that works and deviate from that until you encounter a roadblock. It’s possible that I’m overselling the compatibility of static and SDL config; I can’t figure why it shouldn’t work, but I don’t know that I’ve actually tried it

[alexandra-c]

I rewrite the entire example starting from the handbook and it finally worked...i couldn't figured what was wrong the first time though.. 😐
Many thanks for your help @yaacovCR @gmac !