Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Settings GitHub app to manage repo settings #120

Open
tomkerkhove opened this issue Mar 4, 2021 · 16 comments
Open

Use Settings GitHub app to manage repo settings #120

tomkerkhove opened this issue Mar 4, 2021 · 16 comments
Labels
automation All issues related to automation of processes enhancement New feature or request

Comments

@tomkerkhove
Copy link
Contributor

tomkerkhove commented Mar 4, 2021

Use Settings GitHub app (link) to manage repo settings, instead of our own label tool.

This should be enabled on the organization and our default config added to our GitHub template and existing repos.

@tomkerkhove tomkerkhove added enhancement New feature or request automation All issues related to automation of processes labels Mar 4, 2021
@tomkerkhove
Copy link
Contributor Author

Is this something you'd like to dig into @stijnmoreels?

@stijnmoreels
Copy link
Member

stijnmoreels commented Mar 4, 2021

Is this something you'd like to dig into @stijnmoreels?

👍 Seems like something clearer and better manageable. The risk is however that people with push permissions can change admin things. But our branch restrictions on PR's is maybe enough to circumvent that.

@stijnmoreels
Copy link
Member

Maybe we can add a 'root' config in this repo and inherit from this in the other repo's. That we can can change a single config setting across all repo's at once.

@tomkerkhove
Copy link
Contributor Author

Our branch policies should stop that indeed 👍

I don't know if that app supports the root config though, would have to check but think we can just start with 1 config:1 repo.

@stijnmoreels
Copy link
Member

And I think/hope that with changing the branch policies in the probot config, you will not circumvent existing branch policies. 😅

Yeah, ok, seems reasonable.

@stijnmoreels
Copy link
Member

Hmm, should we first move existing configuration on our repository to such a Probot configuration? Like moving milestones and labels.. I'll first check this in a test repo in our organization.

@tomkerkhove
Copy link
Contributor Author

Sounds good, thanks!

@stijnmoreels
Copy link
Member

Ok, as I expected, it's working in a one-way synchronization. Which means that we have to manually move all the settings from the repo's to the config. We may not have to move everything to this config, so I was wondering, what is useful for us to move to such configuration. Maybe the same things we have now in our GitHub repository tool?

@tomkerkhove
Copy link
Contributor Author

I'd suggest to start with these:

  • repository
  • labels
  • branches

@stijnmoreels
Copy link
Member

Shame we can't add issues here, though. Something we support in our tool

@stijnmoreels
Copy link
Member

Hmm, not sure if I understand correctly, but as I see it, the Probot config is only adding for use the milestones directly automatically. We still have to configure the issues and the branch protection ourselves. Not sure if the Probot is then such an added-value, here, or am I missing something? This is mostly useful for new projects, right? Not with existing.

@tomkerkhove
Copy link
Contributor Author

Are you sure it doesn't work? Because it should.

@stijnmoreels
Copy link
Member

Are you sure it doesn't work? Because it should.

You mean the synchronization? Yeah, pretty sure that it only works one way:

  • Change in file results in change in repo
  • Change in repo doesn't result change in file

@tomkerkhove
Copy link
Contributor Author

No I was referring to the branch policies.

Only one way makes sense, that's what it was built for.

It still has value because we can manage the labels, repo settings and branch policies which is still manual today. Labels can be done through the tool but we never run it anymore, but with this we can add it to our repo template.

@stijnmoreels
Copy link
Member

stijnmoreels commented Mar 5, 2021

No I was referring to the branch policies.

Ah, yes, that works. Some things seems a bit strange and can't be entirely set the way we normally configure the repo, but as close as it gets we can set some branch protection.

The labels are already added to our template, so that's already automated. It's probably mostly about the milestones and the branch policies that Probot can help.

@stijnmoreels
Copy link
Member

stijnmoreels commented Mar 30, 2021

No I was referring to the branch policies.

Ah, yes, that works. Some things seems a bit strange and can't be entirely set the way we normally configure the repo, but as close as it gets we can set some branch protection.

The labels are already added to our template, so that's already automated. It's probably mostly about the milestones and the branch policies that Probot can help.

Hmm, this seems like less and less added value to me since there's only a part that we can do (milestones, 'some' branch policies) while the current tool or manual work still has to do (issues about README, pipelines, CI badge, issues). And otherwise, the tool takes care of that. Maybe we should consider updating the tool to include the branch policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation All issues related to automation of processes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants