Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astro v5 breaks search with pagefind.js 404 on Vercel #332

Closed
blaine-arcjet opened this issue Dec 20, 2024 · 4 comments · Fixed by #335
Closed

Astro v5 breaks search with pagefind.js 404 on Vercel #332

blaine-arcjet opened this issue Dec 20, 2024 · 4 comments · Fixed by #335

Comments

@blaine-arcjet
Copy link
Contributor

I'm getting the follow errors in my console when trying to use search:
Image
@davidmytton davidmytton mentioned this issue Dec 20, 2024
Merged
@davidmytton
Copy link
Contributor

This is a regression in the Vercel adapter:

withastro/astro#12663
withastro/adapters#445

@davidmytton davidmytton changed the title Search is broken Astro v5 breaks search Dec 20, 2024
@davidmytton davidmytton mentioned this issue Dec 20, 2024
Merged
@davidmytton
Copy link
Contributor

Will reopen this until those issues are fixed and we can re-upgrade.

@davidmytton davidmytton reopened this Dec 20, 2024
hartmut-co-uk added a commit to thriving-dev/kafka-streams-topology-design that referenced this issue Jan 6, 2025
@hartmut-co-uk
feat: upgrade astro + starlight || currently builds, but vercel deplo…
edb603d 
…yment error

- sitemaps not available
- search (pagefind) is not working
- gh issues:
  - withastro/adapters#445
  - withastro/astro#12663
  - arcjet/arcjet-docs#332
@davidmytton
Copy link
Contributor

davidmytton commented Jan 16, 2025 •
edited
Loading

The workaround in withastro/adapters#445 (comment) fixes the issue so I was able to upgrade in #370, but I will keep this issue open so we can track the official fix and remove the workaround later.

@davidmytton davidmytton changed the title Astro v5 breaks search Astro v5 breaks search with pagefind.js 404 on Vercel Jan 16, 2025
@davidmytton
Copy link
Contributor

This is fixed in the latest Vercel Astro adapter, so I removed the workaround in #383 and verified it's all working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Downgrade Astro v5 to v4 arcjet/arcjet-docs
2 participants
@davidmytton @blaine-arcjet