-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: It is difficult to verify sample-data that cannot be modified where AMAUAT needs it #851
Labels
AMAUAT
Issues relating to the improvement of the AM Automated Acceptance tests
Comments
ross-spencer
added
AMAUAT
Issues relating to the improvement of the AM Automated Acceptance tests
triage-release-1.11
labels
Aug 7, 2019
Folders and a list of transfers that should be used by sample data for AMAUAT:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe the problem you'd like to be solved.
Noted in this PR where we need some flexibility to modify and add to the sample data repository, there is a slight chance the change will impact AMAUAT testing, where aside from a small number of potential tests, we do need a certain amount of control data to verify the behavior of the system.
Describe the solution you'd like to see implemented.
Audit the range of transfers used across AMAUAT tests, e.g. this Bag Transfer used for
aip-encrpyt-mirror
, and move it, or create new AMAUAT samples in the acceptance-tests folder in the same repository.It would be good to do this change in
1.11
early on in the release, or sometime shortly before testing. We have a much broader PR in-progress right now, that is close to merging, and it would just take a small amount of effort on a number of fronts to verify the efficacy of any changes to sample data at this point.Describe alternatives you've considered.
Aside from the slight chance of minor duplication, e.g. two similar bags in two parts of the sample-data repository. We find benefits when we're free to change an manipulate the sample data used in more regular day-to-day/regression tests to make it more accurate/reliable to every day circumstances (or just more fun!). Similarly with AMAUAT tests.
Should we make this change we might also want to update AMAUAT process documentation and seek to ask developers to create new test data in this folder specifically.
Additional context
Related to: artefactual-labs/archivematica-acceptance-tests#72
Adjacent to: #797
For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Done:
The text was updated successfully, but these errors were encountered: