Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Package extraction can fail in the storage service if a pointer file hasn't been created #616

Open
ross-spencer opened this issue Mar 28, 2019 · 1 comment
Labels
📍 Pointer-files Severity: medium An inconvenient situation where the software is usable but inconvenient or slow. size: 10

Comments

@ross-spencer
Copy link
Contributor

Expected behaviour

The storage service uses the pointer file to determine compression correctly so that re-ingest can work, as well as retrieving files via the API.

Current behaviour

Connected to #594 if a pointer file doesn't exist,then the storage service will fall-back to unar which in the case of some packages created by 7z doesn't always work.

Steps to reproduce

See #594.

Your environment (version of Archivematica, OS version, etc)

AM stable/1.9.0 and qa/0.x

Additional context

There is some work in progress here developed looking at ways to fix #594 but will need to be rebased: artefactual/archivematica-storage-service#441 - the tests developed there should be useful.


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@ross-spencer ross-spencer added the Status: in progress Issue that is currently being worked on. label Apr 4, 2019
@sallain sallain added size: 1 and removed size: 1 labels Sep 27, 2019
@sromkey sromkey changed the title Problem: There is a potential for package extraction to fail in the storage service if a pointer file hasn't been created Problem: Package extraction can fail in the storage service if a pointer file hasn't been created Oct 21, 2019
@sromkey sromkey added the Severity: medium An inconvenient situation where the software is usable but inconvenient or slow. label Oct 21, 2019
@sromkey sromkey added this to the 1.12.0 milestone Jul 6, 2020
@sromkey sromkey removed this from the 1.12.0 milestone Jul 6, 2020
@ross-spencer
Copy link
Contributor Author

Notably #920 is linked to this issue. In #920 the storage service's inability to understand how to extract a bag means it can't submit the package to bagit.py to be checked Further, for more context, the types of file you might try and access but cannot in this scenario is METS file that can be accessed from the Archival Storage tab.

This GIF tries to demonstrate the failure once the pointer file is missing by:

  1. Showing successful download of the METS and Pointer file.
  2. Renames the pointer file so it mimics no longer exisitng/being able to be found.
  3. Shows failure to download METS and pointer (the latter as you'd definitely expect once you've changed a file's name).

2021-02-17-mets-pointer-example

@ross-spencer ross-spencer removed the Status: in progress Issue that is currently being worked on. label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Pointer-files Severity: medium An inconvenient situation where the software is usable but inconvenient or slow. size: 10
Projects
None yet
Development

No branches or pull requests

3 participants