Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the date for hourly results #11

Open
pjayathissa opened this issue Mar 17, 2017 · 3 comments
Open

Setting the date for hourly results #11

pjayathissa opened this issue Mar 17, 2017 · 3 comments
Assignees

Comments

@pjayathissa
Copy link
Contributor

It is not clear how the SimulationPeriod compares with the PV_Result FileName

	SimulationPeriod = {
	'FromMonth': 1, #7, #1,
	'ToMonth': 1,#7, #1,
	'FromDay': 8, #6, #8,
	'ToDay': 8, #8,
	'FromHour': 5,#5
	'ToHour': 20}#20
@MauroLuzzatto
Copy link
Contributor

That's an easy one. There is not connection between the name and the simulation period, I just used names in a way to rember what day respectively simulationperiod I analysed. Hope that helps.

@pjayathissa
Copy link
Contributor Author

However when I change the month numbers, or the FileName I get an error saying that the date is out of range

File "/Users/jayathip/Documents/100_SuAt/190_Software/ASF_Simulation/ASF_Simulation/Simulation_Tool/New_SimulationEnvironment_Ladybug/SimulationClassHourly.py", line 338, in PrepareRadiationData
    self.BuildingRadiationHOY[HOY] = self.HourlyRadiation[monthi][day][hour] #W
KeyError: 2

@MauroLuzzatto
Copy link
Contributor

So, for this particular file of a summer day, I simulated only the hours from 6:00 until 20:00 at July the 6th. Therefore python won't find the data for other simulation periods for this particular file (as you tried with 2 (not sure if you chose the hour, month or day, but it is for sure no data available...). Did this make it clear?

You might want to recalculate the radiation and PV_files, since I there was a bug, which I then fixed (with the hour shift)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants