Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #10

Open
archangelic opened this issue Nov 28, 2017 · 3 comments
Open

Add tests #10

archangelic opened this issue Nov 28, 2017 · 3 comments
Labels
enhancement additional features help wanted idk how to do this

Comments

@archangelic
Copy link
Owner

I feel like, in order for this to be a solid project, it will need some tests. I am way out of my depth with writing tests. So any help would be greatly appreciated!

@archangelic archangelic added the help wanted idk how to do this label Nov 28, 2017
@ghost
Copy link

ghost commented Nov 28, 2017

You can assign this to me. :) I was thinking about tests last night while plunking away at some plugins.

@ghost ghost self-assigned this Nov 28, 2017
@archangelic archangelic assigned ghost and unassigned ghost Nov 28, 2017
@ghost ghost added the enhancement additional features label Nov 28, 2017
@archangelic
Copy link
Owner Author

Is this something that can still be done? I have some thoughts about making the code testable without an irc server.

@Lucidiot
Copy link
Contributor

Lucidiot commented Oct 7, 2018

I will try to make a pull request with a basic unit test and CI configuration already done to at least have that ready.

I will use Travis CI for continuous integration (I can provide a .travis.yml file, but you will have to set that up on your side, as the repo owner) and Coveralls for code coverage (a very important metric to make sure your code is covered by unit tests). There are multiple unit testing frameworks out there for Python but Python's built-in unittest module easily does the job. I will have to make changes to the setup.py and add a section to the README about a proper development setup, or else we could have serious trouble with dependencies between CI and the actual package.

What about linting?

I also can easily setup some linting using flake8. Flake8 is a bundle of tools to perform multiple checks on your code; the actual linting is done by pycodestyle, to fit the PEP 8 style guide, but there are other tools to check for example for unused variables or imports. This is quite useful to prevent some typos and integrates pretty well with IDEs (it is also very easily to use as a CLI). So, my question is:

*waiter voice* Would you like some flake8 with that, @archangelic?

@archangelic archangelic moved this to To-do in pinhook Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement additional features help wanted idk how to do this
Projects
Status: To-do
Development

No branches or pull requests

2 participants