Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arbox/wlapi#5 Add missing dependency #7

Closed
wants to merge 1 commit into from
Closed

Fix arbox/wlapi#5 Add missing dependency #7

wants to merge 1 commit into from

Conversation

janz93
Copy link
Collaborator

@janz93 janz93 commented Apr 25, 2017 •
edited
Loading

[Close #5]

add the missing dependency to have the bundle install command run
without an error

@janz93
Add missing dependency
b113e45 
add the missing dependency to have the bundle install command run
without an error
@janz93
Copy link
Collaborator Author

janz93 commented Apr 25, 2017

Is there a way to view the build details in order to fix the error during the build process on AppVeyo

@janz93 janz93 mentioned this pull request Apr 25, 2017
Closed
@arbox
Copy link
Owner

arbox commented Apr 26, 2017

Do we use actually rainbow directly? Is this our bug?

@janz93
Copy link
Collaborator Author

janz93 commented Apr 26, 2017

rubocop requires it.

rubocop (0.48.1)
      parser (>= 2.3.3.1, < 3.0)
      powerpack (~> 0.1)
      rainbow (>= 1.99.1, < 3.0)

@arbox
Copy link
Owner

arbox commented Apr 26, 2017

I'll investigate this case but we shouldn't add it as our dependency.

@janz93
Copy link
Collaborator Author

janz93 commented Apr 26, 2017

okay sounds good.
Also the failing ci needs to be invested as well.
Is there a way I can help you with that?

@janz93
Copy link
Collaborator Author

janz93 commented Nov 16, 2017

The problem was related to #8

@janz93 janz93 closed this Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janz93 @arbox