From f5939dc2a2c5c52dc887b65c09ce785833b6260c Mon Sep 17 00:00:00 2001 From: Rekard0 <5880388+Rekard0@users.noreply.github.com> Date: Mon, 27 Jan 2025 13:14:11 +0100 Subject: [PATCH] improve comments --- packages/contracts/src/MajorityVotingBase.sol | 2 +- packages/contracts/test/10_unit-testing/11_plugin.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/contracts/src/MajorityVotingBase.sol b/packages/contracts/src/MajorityVotingBase.sol index c09600e0..96364101 100644 --- a/packages/contracts/src/MajorityVotingBase.sol +++ b/packages/contracts/src/MajorityVotingBase.sol @@ -652,7 +652,7 @@ abstract contract MajorityVotingBase is } // For Standard and EarlyExecution modes, check if the support threshold - // has been reached early to determine success while still open. + // has been reached early to determine success while proposal is still open. if (!isSupportThresholdReachedEarly(_proposalId)) { return false; } diff --git a/packages/contracts/test/10_unit-testing/11_plugin.ts b/packages/contracts/test/10_unit-testing/11_plugin.ts index 69b8ca2c..4bc9dc3d 100644 --- a/packages/contracts/test/10_unit-testing/11_plugin.ts +++ b/packages/contracts/test/10_unit-testing/11_plugin.ts @@ -2065,7 +2065,7 @@ describe('TokenVoting', function () { expect(await plugin.isSupportThresholdReachedEarly(id)).to.be.true; expect(await plugin.isMinParticipationReached(id)).to.be.true; expect(await plugin.canExecute(id)).to.equal(false); - // It should return true as voting mode is Standard and proposal is still open, but we know that the proposal hasSucceeded. + // It should return true as voting mode is Standard and proposal is still open, but but thresholds are met. expect(await plugin.hasSucceeded(id)).to.be.true; });