Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): allow null values only for tf variables #8112

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(misconf): allow null values only for tf variables #8112

merged 1 commit into from
Jan 10, 2025
+40 −2

Conversation

nikpivkin
Copy link
Contributor

Description

We should only use null values for variables to preserve the type when passing them to modules.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review January 9, 2025 06:04
@nikpivkin nikpivkin requested a review from simar7 as a code owner January 9, 2025 06:04
@simar7 simar7 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into aquasecurity:main with commit 23dc3a6 Jan 10, 2025
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trivy panics on aws_s3_bucket resource with bucket = null
2 participants
@nikpivkin @simar7