Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FundAccount should wait for txn and confirm success #66

Open
banool opened this issue Jun 13, 2023 · 1 comment
Open

FundAccount should wait for txn and confirm success #66

banool opened this issue Jun 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@banool
Copy link
Contributor

banool commented Jun 13, 2023

The faucet returns a txn hash and the client must wait to see if it succeeds but FundAccount doesn't do that. The client can't wait themselves either easily because we just return ResponseInfo rather than a txn hash directly. FundAccount should use the functions to wait for the txn.

The impact of this is sometimes the SimpleNftExample fails, as will anything else that uses the faucet.

@banool banool added the bug Something isn't working label Jun 13, 2023
@kPatch
Copy link
Contributor

kPatch commented Jun 20, 2023

Good catch. Let me push this in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants