Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant thumbnail loading on screen rotation #7

Open
apsun opened this issue Dec 19, 2020 · 0 comments
Open

Redundant thumbnail loading on screen rotation #7

apsun opened this issue Dec 19, 2020 · 0 comments

Comments

@apsun
Copy link
Owner

apsun commented Dec 19, 2020

info	23:11:27.150118-0800	Keyboard	Loading image untitled folder/test_bmp.bmp using Optional(ImageResizeParams(pointSize=(88.66666666666667, 88.66666666666667), scale=3.0, mode=fill))
info	23:11:29.301033-0800	Keyboard	Loading image untitled folder/test_bmp.bmp using Optional(ImageResizeParams(pointSize=(86.33333333333333, 86.33333333333333), scale=3.0, mode=fill))
info	23:11:29.353497-0800	Keyboard	Loading image untitled folder/test_bmp.bmp using Optional(ImageResizeParams(pointSize=(90.0, 90.0), scale=3.0, mode=fill))

The first one is from the initial load in portrait mode. The second and third are from rotating the phone to landscape.

It's a waste of resources to load these images and then immediately discard them. Would be nice if we could skip the intermediate step and go directly to the target size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant