Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new docs for 1.3.0 new features #236

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

JasonYangShadow
Copy link
Member

@JasonYangShadow JasonYangShadow commented Feb 27, 2024

Description of the Pull Request (PR):

This PR contains new docs for the following new features:

  1. --sharens Add sharens mode for apptainer exec/run/shell apptainer#1760

This fixes or addresses the following GitHub issues:

  • Fixes #

image

Copy link
Contributor

@DrDaveD DrDaveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on the current main to pick up the fix for the CI failure.

@JasonYangShadow JasonYangShadow force-pushed the 1.3_new_feature branch 2 times, most recently from d42025b to 32a8145 Compare February 28, 2024 07:28
mpi.rst Outdated
Note that ``--sharens`` flag requires all spawned processes having the same parent process. This is because these
child processes will join the same namespace identified using the parent process id. To meet the requirement, {Project}
containers should be launched by the same process, e.g. mpirun, and all these containers should be running on the same host.
``--sharens`` does not support sharing the same namespace accross different hosts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this last sentence is redundant, not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! reflected in the latest commit.

Signed-off-by: jason yang <[email protected]>
@DrDaveD DrDaveD merged commit 8b831d1 into apptainer:main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants