From a6f653835ae2be8a9fde69492432c75c91f6283c Mon Sep 17 00:00:00 2001 From: IdosApplitools Date: Thu, 8 Dec 2022 17:49:08 +0200 Subject: [PATCH 1/2] add stitch overlap tests --- coverage-tests.js | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/coverage-tests.js b/coverage-tests.js index b97be4bc..37c419e8 100644 --- a/coverage-tests.js +++ b/coverage-tests.js @@ -1486,6 +1486,35 @@ test('should send dom and location when check region by selector fully with cust // #region OTHERS +test('should send overlap', { + page: 'Default', + config: { + stitchOverlap: 30, + }, + variants: { + '': {vg: false}, + 'with vg': {vg: true}, + // 'on android': {env: {device: 'Samsung Galaxy S8', app: 'https://applitools.jfrog.io/artifactory/Examples/eyes-android-hello-world.apk'}}, + }, + test({driver, eyes}) { + eyes.open({appName: 'Eyes Selenium SDK - overlap', viewportSize}); + eyes.check({isFully: true}); + eyes.close() + }, +}) + +test('should send overlap on android', { + env: {device: 'Samsung Galaxy S8', app: 'https://applitools.jfrog.io/artifactory/Examples/eyes-android-hello-world.apk'}, + config: { + stitchOverlap: 30 + }, + test({driver, eyes}) { + eyes.open({appName: 'Eyes Selenium SDK - overlap', viewportSize}); + eyes.check({isFully: true}); + eyes.close() + }, +}) + test('should send custom batch properties', { page: 'Default', config: { From d4454950d65f1a2aa23e2b854a43e067fd265c7a Mon Sep 17 00:00:00 2001 From: IdosApplitools Date: Mon, 19 Dec 2022 10:24:24 +0200 Subject: [PATCH 2/2] remove unnecessary overlap tests + change overlap test name --- coverage-tests.js | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/coverage-tests.js b/coverage-tests.js index 37c419e8..482659bb 100644 --- a/coverage-tests.js +++ b/coverage-tests.js @@ -1486,29 +1486,15 @@ test('should send dom and location when check region by selector fully with cust // #region OTHERS -test('should send overlap', { +test('should handle stitch overlap', { page: 'Default', config: { stitchOverlap: 30, }, variants: { '': {vg: false}, - 'with vg': {vg: true}, - // 'on android': {env: {device: 'Samsung Galaxy S8', app: 'https://applitools.jfrog.io/artifactory/Examples/eyes-android-hello-world.apk'}}, }, - test({driver, eyes}) { - eyes.open({appName: 'Eyes Selenium SDK - overlap', viewportSize}); - eyes.check({isFully: true}); - eyes.close() - }, -}) - -test('should send overlap on android', { - env: {device: 'Samsung Galaxy S8', app: 'https://applitools.jfrog.io/artifactory/Examples/eyes-android-hello-world.apk'}, - config: { - stitchOverlap: 30 - }, - test({driver, eyes}) { + test({eyes}) { eyes.open({appName: 'Eyes Selenium SDK - overlap', viewportSize}); eyes.check({isFully: true}); eyes.close()