Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doRpc occasionally hangs and does not respect context cancellation #82

Open
elijaharita opened this issue Jun 20, 2022 · 0 comments
Open
Labels
Bug Something isn't working Priority: Low

Comments

@elijaharita
Copy link
Contributor

doRpc sometimes hangs temporarily, followed by a stream reset several seconds later. during this time, context cancellations do nothing.

doRpc takes a context but all it does with it is copy the deadline to the inet stream, so a hanging read or write has no way to close out when the context is canceled.

a quick fix for this would be to start a goroutine that sets the stream deadline to zero if context cancellation is detected, but not sure how much overhead that'll introduce

@elijaharita elijaharita added Bug Something isn't working Priority: Low labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: Low
Projects
None yet
Development

No branches or pull requests

1 participant