Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] If a task is interrupted before mlnotify.end() is called, it runs forver #48

Closed
dcizin opened this issue Oct 6, 2021 · 1 comment
Assignees
Labels

Comments

@dcizin
Copy link
Contributor

dcizin commented Oct 6, 2021

I had to kill a task since it was going to take too long - mltnoify will run forever unless I remember to manually call mlnotify.end(). Forgetting to call end() also prevents me from calling start() - it prints the warning "before hook was already called", which is not the most informative and doesn't tell me that it actually failed to start a new counter. Maybe it should suggest calling mlnotify.end() instead?

@SnirShechter
Copy link
Contributor

Duplicate of #11

@SnirShechter SnirShechter marked this as a duplicate of #11 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants