Add PX4 acro rate curve #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
@apocolipse Can we get it in? Otherwise I'll close and document the PX4 rates in a different way. |
If you can get the HTML and JS updated I'll merge this in, otherwise can leave it open if someone else wants to try it. Once you do that I'll see about updating the proprietary side backend for conversion calculation. |
|
I tried to dive into the web implementation. It's an independent reimplementation and too much effort in my eyes. I'll document in a different way. Thanks anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4
A pile of copy pasting and UI reordering later I added the PX4 acro mode rates implemented here to the Python script of RotorPirates.
I also started adding it to the javascript part but honestly I stranded a bit because there's even more copy pasting and the javascript file used in the HTML is the one from online. Probably there should be a relative path and then local testing would work. @apocolipse any suggestions on that?