Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I add PX4 acro rate parameters to your awsome tool? #4

Open
MaEtUgR opened this issue Jun 6, 2018 · 2 comments
Open

Can I add PX4 acro rate parameters to your awsome tool? #4

MaEtUgR opened this issue Jun 6, 2018 · 2 comments

Comments

@MaEtUgR
Copy link

MaEtUgR commented Jun 6, 2018

Story: Recently we started FPV racing the PX4 flight control firmware on pixracer boards. See https://docs.px4.io/en/frames_multicopter/qav_r_5_kiss_esc_racer.html
It has a lot of features like failsafes, got a lot better in racing performance with airmode, ... and started to support the low cost Omnibus F4 board which stacks onto the 4in1 Hobbywing ESC board.

Issue: The parameters for acro mode which you use for racing are a bit different from e.g. KISS on PX4, it's easier to tune because the values are more independent: you set the maximal rate which stays afterwards and then just shape the curve using expo and superexpo. But the rate stays and superexpo does not screw up expo...

Goal: Your comparing/converting tool is awsome! Am I allowed to add PX4 rates and link it in the official documentation? It should not be complicated, the formula is quite straight forward: https://www.desmos.com/calculator/yze23xmpqc
I would have already made a PR but I don't see where the apparently server side parameter conversions are done https://github.com/apocolipse/RotorPirates/blob/master/js/RotorPirates.js#L74-L80 Is that closed source or am I just blind?

Thanks in advance!

@apocolipse
Copy link
Owner

@MaEtUgR sorry for the late response, feel free to open a PR for displaying the rates. Keep the function similar to the others and I'll add it to the converter (converter itself is closed source)

@MaEtUgR
Copy link
Author

MaEtUgR commented Jan 22, 2019

@apocolipse Sounds good thanks! I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants