-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no nodes persisted in sqlite SQLBackend #50
Comments
Confirming I can reproduce this error on the latest version; looks like we're creating a .journal but not flushing back down to the db file... Will address this asap! |
I just found grand and grand-cypher today while looking for a graph database solution that doesn't require complex installation and such. I am also interested in the status of this, and as an aside, I'd be interested in learning more about these projects/contributing. |
it looks like there backends.SQLBackend doesn't have a commit call on SQLBackend._connection. Should be as simple as adding SQLBackend.commit() and SQLBackend.rollback() functions delegating to the SQLAlchemy connection object. |
submitted a PR for this issue |
Fixed by the awesome @acthecoder23 in #51! |
@j6k4m8 do you have a list of TODOs that i can tackle? I have some cycles i can burn on this. |
wow @acthecoder23 that rocks! would love to chat with you about some of your use-cases and how we can synergize; otherwise there are a few thoughts in #41, including a Neo4j backend, a memgraph backend, a kuzu backend... dynamodb and neptune thoughts are also cool but probably require some cloud dollars... neo4j+dynamo could be perhaps combined into a single cypher backend, just thinking out loud... alternatively i think there's a ton of really high-impact work in performance -- making the sql and dataframes backends more performant in particular (those seem to be our highest-traffic backends). scale (millions of edges to 100s of millions of edges) is a key capability here for sure! also: do you have thoughts on other backends / other dialects we should support? those are definitely high-impact for helping the highest number of users possible! some other ideas are adding more "shortcut" methods to backends, like the adding more benchmarks to codspeed is another big help; it will improve our ability to monitor when PRs help / hurt the library on speed which can be really important for a lot of our users. |
Great work from all of you. Many thanks. |
If I ran
G = Graph(backend=SQLBackend(db_url="sqlite:///demo.db")) G.nx.add_node("A", foo="bar")
demo.db contains tables (grand_Nodes, grand_Edges), but those are empty, no data from the nodes.
The text was updated successfully, but these errors were encountered: