Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightly pinned versions in requirements #21

Closed
AbdealiLoKo opened this issue Oct 10, 2021 · 4 comments · Fixed by #22
Closed

Tightly pinned versions in requirements #21

AbdealiLoKo opened this issue Oct 10, 2021 · 4 comments · Fixed by #22
Labels
help wanted Extra attention is needed

Comments

@AbdealiLoKo
Copy link

Hi, I was trying to use the project. But the tight pins on the requirements, seems to be hindering me from installing it in my virtualenv.

https://github.com/aplbrain/grand/blob/master/setup.py#L18

Can we reduce these constrains to >= so that it's clearer what the minimum requirements are ?

Some notes:

  • I still need to support pandas 0.25
  • Support for lower numpy versions like 1.11 is generally preferred as conda will use that by default
  • SQLAlchemy 1.4 is what I'm using right now - but a bunch of folks are using 1.3 also. There are some backward incompatible changes between them
  • network - I try to use the latest. But am open to trying older versions if needed
@AbdealiLoKo
Copy link
Author

Oh, also - boto3 is prohibited for me as I am not allowed to use AWS resources for some of my projects
Sqlalchemy and boto3 should be extra dependencies maybe

@j6k4m8
Copy link
Member

j6k4m8 commented Oct 10, 2021

@AbdealiJK — thank you for reporting!

Yes, these package restrictions are a bit too tight, and I really should separate the "cloud" flavored requirements out into grand-graph[dynamodb] or something... this week is crazy busy for me but I'll try to find time later this week or next weekend to address this! In the meantime, if you happen to work out a working package requirement list, i'd appreciate it :)

To make this work, I think we'll need to both separate the install reqs into extra-deps, and then also make sure that we don't have any imports anywhere (including in auto-running unit tests...) that depend on them...

@j6k4m8 j6k4m8 added the help wanted Extra attention is needed label Oct 10, 2021
@j6k4m8
Copy link
Member

j6k4m8 commented Oct 22, 2021

@AbdealiJK — let me know if this solves your problem (v0.3.0 is now available)! Feel free to reopen or add a new issue!

@AbdealiLoKo
Copy link
Author

Yes, I am able to install it without hacks now :) Thanks
I am still trying to figure out the SQL backend part, but haven't had much time in the past 2 weeks due to other things

My main objective there is:

  • How do I get my existing database structure mapped to a graph
  • How do I then enable caching in a smart way to avoid unnecessary DB queries as much as possible

Will get back once I get something successful running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants