From 74fc6f1dd9f0fb9fdd06d6517d126af9ba80bd3f Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 10:05:55 +0100 Subject: [PATCH 01/10] link validator CI failing --- .github/workflows/link-validator.yml | 1 + scripts/link-validator.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/link-validator.yml b/.github/workflows/link-validator.yml index e414b0c7c..c8852167c 100644 --- a/.github/workflows/link-validator.yml +++ b/.github/workflows/link-validator.yml @@ -2,6 +2,7 @@ name: Link Validator on: workflow_dispatch: + pull_request: schedule: - cron: '0 6 * * 1' diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index f4b6c9694..f7d1c437f 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -24,6 +24,7 @@ site-link-validator { ignore-files = [ # This file is generated, we can't do much about the invalid links here "license-report.html" + "../../../../docs/target/site/docs/pekko-connectors/snapshot/license-report.html" ] ignore-prefixes = [ From 93cc6d7446534e998ddd23535fdc403d662a863e Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 10:33:56 +0100 Subject: [PATCH 02/10] Update link-validator.conf --- scripts/link-validator.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index f7d1c437f..6127d8570 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -2,7 +2,7 @@ // config for https://github.com/ennru/site-link-validator/ site-link-validator { - root-dir = "./docs/target/site/" + root-dir = "docs/target/site/" # relative to `root-dir` start-file = "docs/pekko-connectors/snapshot/index.html" @@ -24,7 +24,7 @@ site-link-validator { ignore-files = [ # This file is generated, we can't do much about the invalid links here "license-report.html" - "../../../../docs/target/site/docs/pekko-connectors/snapshot/license-report.html" + "docs/target/site/docs/pekko-connectors/snapshot/license-report.html" ] ignore-prefixes = [ From 4cfc56fd762abed1a15cd62d99342e50c26fbb30 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 11:01:21 +0100 Subject: [PATCH 03/10] Update link-validator.conf --- scripts/link-validator.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index 6127d8570..a59f8c8d4 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -24,7 +24,7 @@ site-link-validator { ignore-files = [ # This file is generated, we can't do much about the invalid links here "license-report.html" - "docs/target/site/docs/pekko-connectors/snapshot/license-report.html" + "docs/pekko-connectors/snapshot/license-report.html" ] ignore-prefixes = [ From 8656e27d13fa9b4462f50b2aa7ce543376721b98 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 11:40:52 +0100 Subject: [PATCH 04/10] http links --- scripts/link-validator.conf | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index a59f8c8d4..ee6a81327 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -23,7 +23,6 @@ site-link-validator { ignore-files = [ # This file is generated, we can't do much about the invalid links here - "license-report.html" "docs/pekko-connectors/snapshot/license-report.html" ] @@ -45,5 +44,9 @@ site-link-validator { non-https-whitelist = [ # generated by @apidoc "http://pravega.io/" + # no https support + "http://reactivemongo.org" + # need to investigate why scaladoc links are http + "http://www.scala-lang.org/api" ] } From e63e9aeebf4006978a518852876d23f445eb21b3 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 12:42:19 +0100 Subject: [PATCH 05/10] Update versioning.md --- docs/src/main/paradox/other-docs/versioning.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/main/paradox/other-docs/versioning.md b/docs/src/main/paradox/other-docs/versioning.md index 70cc470c2..60e27ff82 100644 --- a/docs/src/main/paradox/other-docs/versioning.md +++ b/docs/src/main/paradox/other-docs/versioning.md @@ -12,7 +12,7 @@ Apache Pekko Connectors publishes * regular releases to [Maven Central](https://search.maven.org/search?q=g:org.pekko%20pekko-connectors-) * milestone and release candidates (of major versions) to Maven Central -* @ref:[snapshots](snapshots.md) to [Sonatype](https://oss.sonatype.org/content/repositories/snapshots/org/pekko/) +* @ref:[snapshots](snapshots.md) to [repository.apache.org](https://repository.apache.org/content/groups/snapshots/org/apache/pekko/) ### Compatibility From a31273879a0f44a0ac0050e4ded6bf20adccf83a Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 13:53:31 +0100 Subject: [PATCH 06/10] try to fix more issues --- build.sbt | 2 +- scripts/link-validator.conf | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index 8262ad52d..8d34f9abb 100644 --- a/build.sbt +++ b/build.sbt @@ -402,7 +402,7 @@ lazy val docs = project // Pekko gRPC "pekko-grpc.version" -> Dependencies.PekkoGrpcBinaryVersion, "extref.pekko-grpc.base_url" -> s"https://pekko.apache.org/docs/pekko-grpc/${Dependencies.PekkoGrpcBinaryVersion}/%s", - "scaladoc.org.apache.pekko.gprc.base_url" -> s"https://pekko.apache.org/api/pekko-grpc/${Dependencies.PekkoGrpcBinaryVersion}/", + "scaladoc.org.apache.pekko.gprc.base_url" -> s"https://pekko.apache.org/api/pekko-grpc/${Dependencies.PekkoGrpcBinaryVersion}/org/apache/pekko/gprc", // Couchbase "couchbase.version" -> Dependencies.CouchbaseVersion, "extref.couchbase.base_url" -> s"https://docs.couchbase.com/java-sdk/${Dependencies.CouchbaseVersionForDocs}/%s", diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index ee6a81327..839a57be0 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -39,6 +39,8 @@ site-link-validator { "https://mvnrepository.com/artifact/" # Errors in Scaladoc from Google Common header `X-Upload-Content-Type` "https://doc.akka.io/api/akka-http/10.2.9/akka/http/impl/util/" + # Invalid links generated in Google Common Connector scaladoc + "https://pekko.apache.org/api/pekko-http/1.1.0/org/apache/pekko/http/impl/util/" ] non-https-whitelist = [ From a80b29a3394fe6a30ab6af7daad6ffb9ec78d0bc Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 17:08:24 +0100 Subject: [PATCH 07/10] Update link-validator.conf --- scripts/link-validator.conf | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index 839a57be0..1a8ced63e 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -33,6 +33,8 @@ site-link-validator { "https://scala-slick.org/doc/3.3.3/api/" # GitHub will block with "429 Too Many Requests" "https://github.com/" + # Links to azure.microsoft.com work in practice but fail with link validator + "https://azure.microsoft.com/en-us/products/storage/queues/" # Links to datastax.com work in practice but fail with link validator "https://docs.datastax.com/" # MVN repository forbids access after a few requests @@ -40,7 +42,9 @@ site-link-validator { # Errors in Scaladoc from Google Common header `X-Upload-Content-Type` "https://doc.akka.io/api/akka-http/10.2.9/akka/http/impl/util/" # Invalid links generated in Google Common Connector scaladoc - "https://pekko.apache.org/api/pekko-http/1.1.0/org/apache/pekko/http/impl/util/" + "https://pekko.apache.org/api/pekko-http/" + # Invalid links generated in Google Pubsub Connector scaladoc + "https://pekko.apache.org/api/pekko-grpc/" ] non-https-whitelist = [ From 363995c02c6e95da6db8346f469cecfd001dbe95 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 17:24:09 +0100 Subject: [PATCH 08/10] Update link-validator.conf --- scripts/link-validator.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index 1a8ced63e..c36e35513 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -34,7 +34,7 @@ site-link-validator { # GitHub will block with "429 Too Many Requests" "https://github.com/" # Links to azure.microsoft.com work in practice but fail with link validator - "https://azure.microsoft.com/en-us/products/storage/queues/" + "https://azure.microsoft.com/" # Links to datastax.com work in practice but fail with link validator "https://docs.datastax.com/" # MVN repository forbids access after a few requests From 3e5b035842ccb07ae4262c593d57ee8bea94ff69 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 17:26:36 +0100 Subject: [PATCH 09/10] try to fix azure link --- docs/src/main/paradox/azure-storage-queue.md | 2 +- scripts/link-validator.conf | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/src/main/paradox/azure-storage-queue.md b/docs/src/main/paradox/azure-storage-queue.md index 15c821145..a0ba785e9 100644 --- a/docs/src/main/paradox/azure-storage-queue.md +++ b/docs/src/main/paradox/azure-storage-queue.md @@ -2,7 +2,7 @@ The Azure Storage Queue connector provides an Apache Pekko Stream Source and Sinks for Azure Storage Queue integration. -Azure Storage Queue is a queuing service similar to Amazon's SQS. It is designed mostly for long-running and non-time-critical tasks. For more information on Azure Storage Queue see the [Azure docs](https://azure.microsoft.com/en-us/services/storage/queues/). +Azure Storage Queue is a queuing service similar to Amazon's SQS. It is designed mostly for long-running and non-time-critical tasks. For more information on Azure Storage Queue see the [Azure docs](https://azure.microsoft.com/en-us/products/storage/queues). @@project-info{ projectId="azure-storage-queue" } diff --git a/scripts/link-validator.conf b/scripts/link-validator.conf index c36e35513..e5245dbd1 100644 --- a/scripts/link-validator.conf +++ b/scripts/link-validator.conf @@ -33,8 +33,6 @@ site-link-validator { "https://scala-slick.org/doc/3.3.3/api/" # GitHub will block with "429 Too Many Requests" "https://github.com/" - # Links to azure.microsoft.com work in practice but fail with link validator - "https://azure.microsoft.com/" # Links to datastax.com work in practice but fail with link validator "https://docs.datastax.com/" # MVN repository forbids access after a few requests From 8a55337395473169b04b8cfc007fcfeb7087cdbf Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 9 Dec 2024 17:55:40 +0100 Subject: [PATCH 10/10] Update link-validator.yml --- .github/workflows/link-validator.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-validator.yml b/.github/workflows/link-validator.yml index c8852167c..e414b0c7c 100644 --- a/.github/workflows/link-validator.yml +++ b/.github/workflows/link-validator.yml @@ -2,7 +2,6 @@ name: Link Validator on: workflow_dispatch: - pull_request: schedule: - cron: '0 6 * * 1'