From 3460091f0f5e7e5007a569177a95dabbfcbcea6a Mon Sep 17 00:00:00 2001 From: wangzhi16 Date: Fri, 24 Jan 2025 10:05:29 +0800 Subject: [PATCH] Fix compile error. CC: socket/listen.c chip/lpc17_40_i2c.c: In function 'lpc17_40_i2cbus_initialize': chip/lpc17_40_i2c.c:534:29: warning: 'priv' is used uninitialized [-Wuninitialized] 534 | flags = spin_lock_irqsave(&priv->spinlock); | ^~~~~~~~~~~~~~~ chip/lpc17_40_i2c.c:529:29: note: 'priv' was declared here 529 | struct lpc17_40_i2cdev_s *priv; | ^~~~ Signed-off-by: wangzhi16 --- arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c | 5 ----- arch/arm/src/lpc43xx/lpc43_i2c.c | 5 ----- arch/arm/src/lpc54xx/lpc54_i2c_master.c | 5 ----- 3 files changed, 15 deletions(-) diff --git a/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c b/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c index 5b65332917628..74e22a466e8d8 100644 --- a/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c +++ b/arch/arm/src/lpc17xx_40xx/lpc17_40_i2c.c @@ -531,8 +531,6 @@ struct i2c_master_s *lpc17_40_i2cbus_initialize(int port) irqstate_t flags; uint32_t regval; - flags = spin_lock_irqsave(&priv->spinlock); - #ifdef CONFIG_LPC17_40_I2C0 if (port == 0) { @@ -621,13 +619,10 @@ struct i2c_master_s *lpc17_40_i2cbus_initialize(int port) else #endif { - spin_unlock_irqrestore(&priv->spinlock, flags); i2cerr("ERROR: LPC I2C Only supports ports 0, 1 and 2\n"); return NULL; } - spin_unlock_irqrestore(&priv->spinlock, flags); - putreg32(I2C_CONSET_I2EN, priv->base + LPC17_40_I2C_CONSET_OFFSET); /* Attach Interrupt Handler */ diff --git a/arch/arm/src/lpc43xx/lpc43_i2c.c b/arch/arm/src/lpc43xx/lpc43_i2c.c index 8d1c8a478ebee..9a7c99d8c18a0 100644 --- a/arch/arm/src/lpc43xx/lpc43_i2c.c +++ b/arch/arm/src/lpc43xx/lpc43_i2c.c @@ -462,8 +462,6 @@ struct i2c_master_s *lpc43_i2cbus_initialize(int port) irqstate_t flags; uint32_t regval; - flags = spin_lock_irqsave(&priv->spinlock); - #ifdef CONFIG_LPC43_I2C0 if (port == 0) { @@ -523,12 +521,9 @@ struct i2c_master_s *lpc43_i2cbus_initialize(int port) else #endif { - spin_unlock_irqrestore(&priv->spinlock, flags); return NULL; } - spin_unlock_irqrestore(&priv->spinlock, flags); - putreg32(I2C_CONSET_I2EN, priv->base + LPC43_I2C_CONSET_OFFSET); /* Attach Interrupt Handler */ diff --git a/arch/arm/src/lpc54xx/lpc54_i2c_master.c b/arch/arm/src/lpc54xx/lpc54_i2c_master.c index ead84fadfc109..14876771a18bc 100644 --- a/arch/arm/src/lpc54xx/lpc54_i2c_master.c +++ b/arch/arm/src/lpc54xx/lpc54_i2c_master.c @@ -914,8 +914,6 @@ struct i2c_master_s *lpc54_i2cbus_initialize(int port) i2cinfo("port=%d\n", port); - flags = spin_lock_irqsave(&priv->spinlock); - /* Configure the requestin I2C peripheral */ /* NOTE: The basic FLEXCOMM initialization was performed in @@ -1263,13 +1261,10 @@ struct i2c_master_s *lpc54_i2cbus_initialize(int port) else #endif { - spin_unlock_irqrestore(&priv->spinlock, flags); i2cerr("ERROR: Unsupported port=%d\n", port); return NULL; } - spin_unlock_irqrestore(&priv->spinlock, flags); - /* Install our operations */ priv->dev.ops = &lpc54_i2c_ops;