[#6152] refactor: Refactor tag commands in Gravitino CLI #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmclean
changed the title
|
It looks like one of the tag tests is failing. Try setting Main.useExit to false to see which test it is. |
frankvicky
force-pushed
the
6152
branch
2 times, most recently
from
c200bb1 to
07b8113
Compare
|
Hi @justinmclean
|
clients/cli/src/main/java/org/apache/gravitino/cli/TagCommandHandler.java
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/TagCommandHandler.java
Outdated
Show resolved
Hide resolved
justinmclean
previously approved these changes
Jan 14, 2025
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 14, 2025
…e#6192) ### What changes were proposed in this pull request? Reduce complexity in `GravitinoCommandLine` ### Why are the changes needed? For readability and maintainability. Fix: apache#6152 ### Does this PR introduce _any_ user-facing change? (Please list the user-facing changes introduced by your change, including None. ### How was this patch tested? Tested locally. --------- Co-authored-by: Justin Mclean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reduce complexity in
GravitinoCommandLineWhy are the changes needed?
For readability and maintainability.
Fix: #6152
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
None.
How was this patch tested?
Tested locally.