[#6136] refactor: move check for enable and disable within validate #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinmclean Is this what you envisioned when creating the issue? I was a bit confused by the wording. |
|
Had to modify to support the newly-refactored commands, but now should be ready for review @justinmclean |
| spy( | ||
| new GravitinoCommandLine( | ||
| mockCommandLine, mockOptions, CommandEntities.CATALOG, CommandActions.UPDATE)); | ||
| new CatalogEnable( |
There was a problem hiding this comment.
This should be GravitinoCommandLine not CatalogEnable
There was a problem hiding this comment.
Updated test to use GravitinoCommandLine.
| spy( | ||
| new GravitinoCommandLine( | ||
| mockCommandLine, mockOptions, CommandEntities.METALAKE, CommandActions.UPDATE)); | ||
| new MetalakeEnable( |
There was a problem hiding this comment.
This needs to be GravitinoCommandLine not MetalakeEnable
There was a problem hiding this comment.
Updated test to use GravitinoCommandLine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The check for enable and disable was within
GravitinoCommandLine.java, not inside thevalidate()logic as it should be.Why are the changes needed?
To keep consistency within the codebase and making sure the
validate()method for a command is being used effectivelyFix: #6136
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated tests and ran local test suite successfully.