Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] make Java GVFS configuration simple #6130

Open
mchades opened this issue Jan 7, 2025 · 2 comments
Open

[Improvement] make Java GVFS configuration simple #6130

mchades opened this issue Jan 7, 2025 · 2 comments
Labels
improvement Improvements on everything

Comments

@mchades
Copy link
Contributor

mchades commented Jan 7, 2025

What would you like to be improved?

The two Configuration item in Java GVFS seem to have fixed values, I think we can make them optional:

| Configuration item | Description | Default value | Required | Since version |
|-------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|-------------------------------------|-----------------|
| `fs.AbstractFileSystem.gvfs.impl` | The Gravitino Virtual File System abstract class, set it to `org.apache.gravitino.filesystem.hadoop.Gvfs`. | (none) | Yes | 0.5.0 |
| `fs.gvfs.impl` | The Gravitino Virtual File System implementation class, set it to `org.apache.gravitino.filesystem.hadoop.GravitinoVirtualFileSystem`. | (none) | Yes | 0.5.0 |

How should we improve?

make them optional and give them default values

@mchades mchades added the improvement Improvements on everything label Jan 7, 2025
@mchades
Copy link
Contributor Author

mchades commented Jan 7, 2025

@yuqi1129 could you plz help to confirm?

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jan 7, 2025

@yuqi1129 could you plz help to confirm?

Theoretically, we can utilize the service loader mechanism to optimize it. any paths that starts with gvfs will automatically use GravitinoVirtualFileSystem as the default implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

2 participants