Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organize and rename aggregates physical plan #2387

Closed
yjshen opened this issue Apr 30, 2022 · 0 comments · Fixed by #2388
Closed

Re-organize and rename aggregates physical plan #2387

yjshen opened this issue Apr 30, 2022 · 0 comments · Fixed by #2388
Labels
enhancement New feature or request

Comments

@yjshen
Copy link
Member

yjshen commented Apr 30, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

  • We currently have a hash-based implementation, GroupedHashAggregateStream for aggregate with grouping keys, and a non-hash implementation for aggregate without grouping keys but named HashAggregateStream.
  • We could further enrich the aggregation method from hash-based to sort-based at runtime when we are run out of memory, as described in Memory Limited GroupBy (Externalized / Spill) #1570

Describe the solution you'd like

  1. Promote hash_aggregates to a directory aggregates, and re-organize code inside this aggregates module.
  2. Rename HashAggregateExec to AggregateExec, since it's not always hashing.

Describe alternatives you've considered
Don't move

Additional context
Add any other context or screenshots about the feature request here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-organize and rename aggregates physical plan yjshen/datafusion
1 participant
@yjshen