-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement bitmap_distinct function using bitmap #1823
Comments
i have implement a initial version get below result:
the bitmap used is this |
Could you please file the draft of the pull request? |
Test result of use 1million_rows_10thousand_distinct.parquet
1million_1million.parquet
|
IOx is using croaring for its "ReadBuffer" (an optimized in memory format we use rather than straight up RecordBatches). Specifically: Sorry for the delayed response |
Hey @Ted-Jiang! Nice to see some of these ideas making there way into Datafusion! I developed some of these ideas for IOx's Read Buffer happened in 2020. At the time I chose
The TLDR of how I use bitmaps in the Read Buffer is as follows:
|
Hi @e-dard Thanks a lot for your info! What an admirable work in IOx. |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Like #1115 implement
u8, i8, u16, i16, u32, i32
by using bitmap calledbitmap_distinct
Describe the solution you'd like
I will use
arrow-bitmap
and roaring-bitmap and check the performance of bothThe text was updated successfully, but these errors were encountered: