Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Unicode function to invoke_with_args #14709

Closed
goldmedal opened this issue Feb 17, 2025 · 7 comments · Fixed by #14856 · May be fixed by #14779
Closed

Migrate Unicode function to invoke_with_args #14709

goldmedal opened this issue Feb 17, 2025 · 7 comments · Fixed by #14856 · May be fixed by #14779
Assignees
@onlyjackfrost @fakoredeDamilola @aviral-bhardwaj @sidshehria
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@goldmedal
Copy link
Contributor

Is your feature request related to a problem or challenge?

As #14652, invoke_batch is deprecated. We should migrate all the UDFs to invoke_with_args. This issue would focus on the function in the datafusion/functions/src/unicode.

Describe the solution you'd like

  • Remove invoke_batch for the function implementation and use implement invoke_with_args instead.

Describe alternatives you've considered

No response

Additional context

No response
@goldmedal goldmedal added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2025
@niebayes niebayes mentioned this issue Feb 17, 2025
Closed
@fakoredeDamilola
Copy link

Hello, please I would like to worok on this issue.

@goldmedal
Copy link
Contributor Author

Hello, please I would like to worok on this issue.

Thanks @fakoredeDamilola. Feel free to use take keyword to asign yourself.

@fakoredeDamilola
Copy link

take

@sidshehria
Copy link

take

@aviral-bhardwaj
Copy link

take

@sidshehria
Copy link

done and resolved this issue kindly review my pull request
https://github.com/apache/datafusion/pull/14779

@goldmedal goldmedal mentioned this issue Feb 20, 2025
Draft
@onlyjackfrost onlyjackfrost mentioned this issue Feb 24, 2025
Merged
@onlyjackfrost
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onlyjackfrost onlyjackfrost

@fakoredeDamilola fakoredeDamilola

@aviral-bhardwaj aviral-bhardwaj

@sidshehria sidshehria

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@goldmedal @onlyjackfrost @fakoredeDamilola @aviral-bhardwaj @sidshehria