Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regexp slt tests to refactor out string type tests, cleanup #14452

Open
Omega359 opened this issue Feb 3, 2025 · 1 comment
Open

Update regexp slt tests to refactor out string type tests, cleanup #14452

Omega359 opened this issue Feb 3, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Omega359 commented Feb 3, 2025

Is your feature request related to a problem or challenge?

The regexp.slt test file currently contains tests for regexp_count, regexp_like, regexp_match and regexp_replace functions and do simple tests for acceptable of different string types (just utf8 and ut8view currently).

This test file should be refactored in a similar manner to how the string tests were refactored in #12525 to clean up the testing and extract out the test for each function into their own file.

Describe the solution you'd like

A clean and clear set of test files where testing the string types accepted is clear and reuses common queries similar to how the string tests are done.

Describe alternatives you've considered

No response

Additional context

No response

@Omega359 Omega359 added the enhancement New feature or request label Feb 3, 2025
@Omega359
Copy link
Contributor Author

Omega359 commented Feb 3, 2025

Follow up to #14449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant