Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approx_distinct should be leveraging bitmap for counting u8/16 and i8/16 #1109

Open
jimexist opened this issue Oct 12, 2021 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@jimexist
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

approx_distinct should be leveraging bitmap for counting u8/16 and i8/16

Describe the solution you'd like

Using a bitmap is more efficient

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Weijun-H
Copy link
Member

Weijun-H commented Dec 7, 2023

Why don't we also support u32/i32 🤔 ?

@alamb
Copy link
Contributor

alamb commented Dec 7, 2023

there is no reason I know of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants