Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

649 Adding soundex expression for all dialects #650

Closed
wants to merge 2 commits into from
Closed

649 Adding soundex expression for all dialects #650

wants to merge 2 commits into from

Conversation

AugustoFKL
Copy link
Contributor

Adding SOUNDEX expression parsing. As mentioned in the issue, there are A LOT of dialects that implement the almost same structure for Soundex, and, therefore, there's no reason for me to restrict the dialect that is parsing, as at least 5 of them have it.

Common Soundex expressions:

SELECT SOUNDEX('Hello');

SELECT * FROM tb WHERE SOUNDEX(id) = SOUNDEX('Hello');

Resolves: #649

@coveralls
Copy link

coveralls commented Oct 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3170432588

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.599%
Totals Coverage Status
Change from base Build 3166221109: 0.02%
Covered Lines: 10206
Relevant Lines: 11923
💛 - Coveralls

@AugustoFKL AugustoFKL closed this Oct 4, 2022
@AugustoFKL AugustoFKL deleted the 649_support-soundex-expression branch October 4, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for SOUNDEX expression, restrict to MySQL, MSSQL, Oracle, and Generic Dialect
2 participants
@AugustoFKL @coveralls