Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor configuration extended .. #1099

Merged
merged 12 commits into from
Oct 31, 2024

Conversation

milenkovicm
Copy link
Contributor

@milenkovicm milenkovicm commented Oct 24, 2024

... this provide much more options to configure executors.

Which issue does this PR close?

Closes #1098.

Rationale for this change

expose more configuration options for executor and scheduler, this way users can set up their own instances with custom configuration (object stores, configuration, udfs ...)

What changes are included in this PR?

  • Integration tests have been added which rely on testcontainers infrastructure, thus docker is required for builds. Tests are disabled by default but can be enabled with testcontainers option
  • BALLISTA_PLANNER_OVERRIDE config was removed, there is equivalent method in SessionConfigExt
  • BallistaFunctionRegistry was promoted a bit, cleaning up executor code
  • executor code cleanup

to follow up

  • session cofiguration to be propagated from scheduler to executor
  • configuration clean up

Are there any user-facing changes?

there are slight changes in original API, but not drastic

@milenkovicm milenkovicm marked this pull request as draft October 24, 2024 19:15
@milenkovicm
Copy link
Contributor Author

will be finalised once #1096 gets merged

... this way we can configure way more options
@milenkovicm milenkovicm force-pushed the reloaded_executor_config branch 2 times, most recently from cb82c7b to 5d990a7 Compare October 26, 2024 18:42
@milenkovicm milenkovicm force-pushed the reloaded_executor_config branch from 5d990a7 to 9f8bc2f Compare October 26, 2024 20:42
@milenkovicm milenkovicm marked this pull request as ready for review October 26, 2024 20:43
@milenkovicm milenkovicm marked this pull request as draft October 26, 2024 21:05
@milenkovicm milenkovicm marked this pull request as ready for review October 26, 2024 21:51
@milenkovicm
Copy link
Contributor Author

SessionContextExt finally provides enough configuration options, getting one step closer to ballista library. I will follow up with documentation update reflecting new interface and removal of object stores.

please have a look when you get chance @andygrove

@milenkovicm milenkovicm marked this pull request as draft October 26, 2024 23:03
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @milenkovicm

@milenkovicm
Copy link
Contributor Author

Thanks @andygrove, I need another pass to clean it up and put documention. Will let you know when ready

so executors can configure runtime per task,
and session config they have
@milenkovicm milenkovicm force-pushed the reloaded_executor_config branch from 8194b5a to c83a158 Compare October 27, 2024 16:48
@milenkovicm milenkovicm marked this pull request as ready for review October 28, 2024 07:56
@milenkovicm
Copy link
Contributor Author

i believe this is ready now @andygrove
thanks for your patience

@milenkovicm milenkovicm changed the title Executor configuration accepts SessionState .. Executor configuration extended .. Oct 28, 2024
in default configuration as ballista disables them
@andygrove andygrove merged commit cd80095 into apache:main Oct 31, 2024
15 checks passed
@milenkovicm milenkovicm deleted the reloaded_executor_config branch November 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more configuration options for executor
2 participants