Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release arrow-rs / parquet minor version 54.2.0 (~Mar~ Feb 2025) #7083

Open
2 of 6 tasks
alamb opened this issue Feb 6, 2025 · 12 comments
Open
2 of 6 tasks

Release arrow-rs / parquet minor version 54.2.0 (~Mar~ Feb 2025) #7083

alamb opened this issue Feb 6, 2025 · 12 comments
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Feb 6, 2025

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Our release schedule is here https://github.com/apache/arrow-rs?tab=readme-ov-file#release-versioning-and-schedule

Items to fix before the release:

Wishlist Items

Describe the solution you'd like

Create a release

Describe alternatives you've considered

Additional context

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Feb 6, 2025
@alamb
Copy link
Contributor Author

alamb commented Feb 6, 2025

Realistically I can't do both this release and the object store on the same week

@alamb alamb changed the title Release arrow-rs / parquet minor version 54.2.0 (Feb 2025) Release arrow-rs / parquet minor version 54.2.0 (Mar 2025) Feb 6, 2025
@alamb alamb changed the title Release arrow-rs / parquet minor version 54.2.0 (Mar 2025) Release arrow-rs / parquet minor version 54.2.0 (Mar 2025) Feb 6, 2025
@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2025

We have discovered a regression

@Blizzara has requested a release with this fix

I therefore plan to make a 54.2.0 release later this week

@alamb alamb changed the title Release arrow-rs / parquet minor version 54.2.0 (Mar 2025) Release arrow-rs / parquet minor version 54.2.0 (~Mar~ Feb 2025) Feb 10, 2025
@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2025

Since main is still the 54.x line and the fix has already been merged

I'll plan to make a release directly from main

FYI @tustvold and @Jefffrey @etseidl

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

I tested the pre-release update of 54.2.0 with DataFusion

It turns out that arrow has rand in the public API as part of the bench_util and I got a few compile errors like

error[E0599]: the method `gen` exists for struct `StdRng`, but its trait bounds were not satisfied
  --> datafusion/functions-aggregate/benches/array_agg.rs:64:27
   |
64 |         let is_null = rng.gen::<f32>() < null_density;
   |                           ^^^ method cannot be called on `StdRng` due to unsatisfied trait bounds
   |
  ::: /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rand-0.9.0/src/rngs/std.rs:70:1
   |
70 | pub struct StdRng(Rng);
   | ----------------- doesn't satisfy `rand::rngs::std::StdRng: rand::RngCore` or `rand::rngs::std::StdRng: rand::Rng`
   |
   = note: the following trait bounds were not satisfied:
           `rand::rngs::std::StdRng: rand::RngCore`
           which is required by `rand::rngs::std::StdRng: rand::Rng`
   = help: items from traits can only be used if the trait is in scope
help: trait `Rng` which provides `gen` is implemented but not in scope; perhaps you want to import it
   |
18 + use rand::rng::Rng;

There are two potential solutions I can think of

  1. (the nicest) revert the upgrade to rand
  2. (the easiest) Publicly export rand so the correct version can be used in the API

I am going to make a PR for 2

@tustvold
Copy link
Contributor

I am going to make a PR for 2

Won't that still be a breaking change?

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

I am going to make a PR for 2

Won't that still be a breaking change?

Yes

@tustvold
Copy link
Contributor

tustvold commented Feb 12, 2025

In which case it can't be released as 54.2.0?

Edit: I don't see a way to avoid reverting #7045

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

In which case it can't be released as 54.2.0?

Edit: I don't see a way to avoid reverting #7045

Yes I suppose you are right -- I will prepare some PRs to do so

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

Ok, I reverted the rand upgrade and verified the datafusion upgrade went smoothly:

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

I am working on updating the release notes and will prepare an RC

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2025

I have created a release candidate and begun the voting:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants