From 3cca3a1dec91af3cd606078e228ed5faa28bcd42 Mon Sep 17 00:00:00 2001 From: Stefan Hattrell <29941279+digorgonzola@users.noreply.github.com> Date: Wed, 24 Jan 2024 11:22:44 +1100 Subject: [PATCH] github: remove deployment job and rename to "build" --- ...oy-production.yml => build-production.yml} | 72 ++++++++++--------- .../{deploy-staging.yml => build-staging.yml} | 71 +++++++++--------- 2 files changed, 76 insertions(+), 67 deletions(-) rename .github/workflows/{deploy-production.yml => build-production.yml} (52%) rename .github/workflows/{deploy-staging.yml => build-staging.yml} (52%) diff --git a/.github/workflows/deploy-production.yml b/.github/workflows/build-production.yml similarity index 52% rename from .github/workflows/deploy-production.yml rename to .github/workflows/build-production.yml index db110f9..1f23529 100644 --- a/.github/workflows/deploy-production.yml +++ b/.github/workflows/build-production.yml @@ -64,38 +64,42 @@ jobs: env: digest: ${{ steps.build_and_push.outputs.digest }} - deploy: - runs-on: ubuntu-latest - environment: production - needs: [build_push] - steps: - - name: Configure AWS Credentials - uses: aws-actions/configure-aws-credentials@v4 - with: - audience: sts.amazonaws.com - aws-region: ${{ vars.AWS_REGION }} - role-to-assume: ${{ secrets.AWS_ROLE_ARN }} - - - name: Get Currently Running Task Definition - id: get-current-task-definition - run: | - aws ecs describe-task-definition \ - --task-definition ${{ vars.FAMILY }} \ - --query taskDefinition > task-definition.json +# Optional deployment job if you want to update the task immediately +# However, the appdeploy repository is configured to run drift jobs on an hourly basis +# See: https://terrateam.io/docs/features/drift-detection - - name: Update Task Definition with Image Digest - id: update-api-image-tag - uses: aws-actions/amazon-ecs-render-task-definition@v1 - with: - task-definition: task-definition.json - container-name: app - image: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}@${{ needs.build_push.outputs.image_digest }} - - - name: Deploy to Amazon ECS service - uses: aws-actions/amazon-ecs-deploy-task-definition@v1 - with: - task-definition: ${{ steps.update-api-image-tag.outputs.task-definition }} - service: ${{ vars.FAMILY }} - cluster: ${{ vars.CLUSTER }} - force-new-deployment: true - wait-for-service-stability: true +# deploy: +# runs-on: ubuntu-latest +# environment: production +# needs: [build_push] +# steps: +# - name: Configure AWS Credentials +# uses: aws-actions/configure-aws-credentials@v4 +# with: +# audience: sts.amazonaws.com +# aws-region: ${{ vars.AWS_REGION }} +# role-to-assume: ${{ secrets.AWS_ROLE_ARN }} +# +# - name: Get Currently Running Task Definition +# id: get-current-task-definition +# run: | +# aws ecs describe-task-definition \ +# --task-definition ${{ vars.FAMILY }} \ +# --query taskDefinition > task-definition.json +# +# - name: Update Task Definition with Image Digest +# id: update-api-image-tag +# uses: aws-actions/amazon-ecs-render-task-definition@v1 +# with: +# task-definition: task-definition.json +# container-name: app +# image: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}@${{ needs.build_push.outputs.image_digest }} +# +# - name: Deploy to Amazon ECS service +# uses: aws-actions/amazon-ecs-deploy-task-definition@v1 +# with: +# task-definition: ${{ steps.update-api-image-tag.outputs.task-definition }} +# service: ${{ vars.FAMILY }} +# cluster: ${{ vars.CLUSTER }} +# force-new-deployment: true +# wait-for-service-stability: true diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/build-staging.yml similarity index 52% rename from .github/workflows/deploy-staging.yml rename to .github/workflows/build-staging.yml index 3e2ae0c..ab9e44e 100644 --- a/.github/workflows/deploy-staging.yml +++ b/.github/workflows/build-staging.yml @@ -65,38 +65,43 @@ jobs: env: digest: ${{ steps.build_and_push.outputs.digest }} - deploy: - runs-on: ubuntu-latest - environment: staging - needs: [build_push] - steps: - - name: Configure AWS Credentials - uses: aws-actions/configure-aws-credentials@v4 - with: - audience: sts.amazonaws.com - aws-region: ${{ vars.AWS_REGION }} - role-to-assume: ${{ secrets.AWS_ROLE_ARN }} - - - name: Get Currently Running Task Definition - id: get-current-task-definition - run: | - aws ecs describe-task-definition \ - --task-definition ${{ vars.FAMILY }} \ - --query taskDefinition > task-definition.json - - name: Update Task Definition with Image Digest - id: update-api-image-tag - uses: aws-actions/amazon-ecs-render-task-definition@v1 - with: - task-definition: task-definition.json - container-name: app - image: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}@${{ needs.build_push.outputs.image_digest }} +# Optional deployment job if you want to update the task immediately +# However, the appdeploy repository is configured to run drift jobs on an hourly basis +# See: https://terrateam.io/docs/features/drift-detection - - name: Deploy to Amazon ECS service - uses: aws-actions/amazon-ecs-deploy-task-definition@v1 - with: - task-definition: ${{ steps.update-api-image-tag.outputs.task-definition }} - service: ${{ vars.FAMILY }} - cluster: ${{ vars.CLUSTER }} - force-new-deployment: true - wait-for-service-stability: true +# deploy: +# runs-on: ubuntu-latest +# environment: staging +# needs: [build_push] +# steps: +# - name: Configure AWS Credentials +# uses: aws-actions/configure-aws-credentials@v4 +# with: +# audience: sts.amazonaws.com +# aws-region: ${{ vars.AWS_REGION }} +# role-to-assume: ${{ secrets.AWS_ROLE_ARN }} +# +# - name: Get Currently Running Task Definition +# id: get-current-task-definition +# run: | +# aws ecs describe-task-definition \ +# --task-definition ${{ vars.FAMILY }} \ +# --query taskDefinition > task-definition.json +# +# - name: Update Task Definition with Image Digest +# id: update-api-image-tag +# uses: aws-actions/amazon-ecs-render-task-definition@v1 +# with: +# task-definition: task-definition.json +# container-name: app +# image: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}@${{ needs.build_push.outputs.image_digest }} +# +# - name: Deploy to Amazon ECS service +# uses: aws-actions/amazon-ecs-deploy-task-definition@v1 +# with: +# task-definition: ${{ steps.update-api-image-tag.outputs.task-definition }} +# service: ${{ vars.FAMILY }} +# cluster: ${{ vars.CLUSTER }} +# force-new-deployment: true +# wait-for-service-stability: true