Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hourly_timeseries.py output_path argument should be output_dir #135

Closed
mhidas opened this issue Feb 22, 2021 · 1 comment
Closed

hourly_timeseries.py output_path argument should be output_dir #135

mhidas opened this issue Feb 22, 2021 · 1 comment
Labels
bug Something isn't working hourly_timeseries Issues relating to the hourly time series product

Comments

@mhidas
Copy link
Contributor

mhidas commented Feb 22, 2021

From @mphemming:

Thought this might be a good place to mention that I ran into an error when creating hourly timeseries products locally. Using the latest code on Github, I had to change output_dir=args.output_path on line 579 in 'hourly_timeseries.py' to output_dir=args.output_dir for the code to work. Easy fix but worth mentioning.

@mhidas mhidas added bug Something isn't working hourly_timeseries Issues relating to the hourly time series product labels Feb 22, 2021
@mhidas
Copy link
Contributor Author

mhidas commented Feb 22, 2021

There's an open PR to standardise and simplify these command-line arguments: #120 , which now includes the necessary fix above.

@mphemming feel free to take a look and let us know if the code on that branch works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hourly_timeseries Issues relating to the hourly time series product
Projects
None yet
Development

No branches or pull requests

1 participant