Reference to undefined IMOS.templates.dimensions.adcp_remapped

[sspagnol]

In Parser/OceanContour/OceanContour.m line 667 there is a code

dimensions = IMOS.templates.dimensions.adcp_remapped;

but this does not exist in Util/+IMOS/+templates/dimensions.m, so not sure how oceanContourParser ever worked.

[lbesnard]

@sspagnol I found the same issue while trying to debug #775

I emailed @ocehugo to understand how this parser is meant to work.

At L440 (https://github.com/aodn/imos-toolbox/blob/master/Parser/OceanContour/OceanContour.m#L440 ), the following file should automatically be tested by the docstrings unittests written by hugo:

% file = [toolboxRootPath 'data/testfiles/netcdf/Nortek/OceanContour/Signature/s500_enu_avg.nc'];

However, running the toolbox with this file fails at L647 with the following error:

The class IMOS.templates.dimensions has no Constant property or Static method named 'adcp_remapped'.

Error in OceanContour.readOceanContourFile (line 647)
                dimensions = IMOS.templates.dimensions.adcp_remapped;

The only other reference is here:

imos-toolbox/Util/+IMOS/gen_dimensions.m

Line 9 in bf62109

% mode [str] - ['timeSeries','profile','adcp_raw','adcp_remapped'].

[lbesnard]

fixed by #774