-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CF: decibel unit no yet implemented in UDUNITS #15
Comments
@ggalibert @smancini According to Geonetwork the unit "Decibels" is only used in ABOS and ANMN current velocity data. Do you know of others? |
Reported to IOOS: ioos#137 |
Don't know any other facility using decibel unit. |
This issue has also been reported against the cf_units package, a wrapper for UDUNITS2, which is what the checker uses to assess the validity of units: SciTools/cf-units#30 |
Ok, just to take some notes for myself : Would be good to talk about that with @danfruehauf . |
As discussed yesterday, the tradeoff is between more control vs. more maintenance. If we instantly fork the repository and maintain it ourselves, we're taking on ourselves the task of maintaining it automatically. We need to think carefully whether we want this responsibility. Once we do it, going back is hard. Ideally, it'd be good to put pressure on UDUNITS to include those units from CF. Since we cannot, I suggest we pull from upstream both UDUNITS and CF and make them play along, perhaps auto-generating combined files or something. This way we can enjoy reduced maintenance and also more control (we can choose what UDUNITS and CF versions we want as long as they don't collide). At the moment, UDUNITS is in the |
@mhidas let's discuss this on Monday. In the meantime I created a pull request on data-services to add decibel there : aodn/data-services#189 . |
For now this is fixed via aodn/data-services#189 |
The ADCP variable backscatter_intensity_from_acoustic_beam has a unit attribut
decibel
.The netcdf-checker ouput is
why ABSI1 is set as
known
although there is no standard name, and the variable doesn't exist in the CF convention ?the CF FAQ says decibel will be in future version http://cfconventions.org/faq.html
What do to in the meantime ?
The text was updated successfully, but these errors were encountered: