Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove List suffix in generated code #73

Open
ChloePlanet opened this issue Apr 16, 2020 · 1 comment
Open

Remove List suffix in generated code #73

ChloePlanet opened this issue Apr 16, 2020 · 1 comment
Labels
P1 Medium priority

Comments

@ChloePlanet
Copy link
Contributor

For sysl endpoints

Simple "Simple Server" [package="simple"]:
    @basePath = "/simple"
    @go_package = "simple"

    /just-return-ok:
        GET:
            return ok

should remove List suffix in requestrouter.go, service.go, servicehandler.go, serviceinterface.go:

- // GetJustOkAndJustErrorList ...
+ // GetJustOkAndJustError ...
- func (s *Client) GetJustOkAndJustErrorList(ctx context.Context, req *GetJustOkAndJustErrorListRequest) (*http.Header, error) {
+ func (s *Client) GetJustOkAndJustError(ctx context.Context, req *GetJustOkAndJustErrorRequest) (*http.Header, error) {
    // ...
}
@ChloePlanet
Copy link
Contributor Author

@gkanz any context for why we add List suffix the first time?

@ChloePlanet ChloePlanet added the P1 Medium priority label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant