Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger configuration #6

Open
nofun97 opened this issue Jan 27, 2020 · 1 comment
Open

Logger configuration #6

nofun97 opened this issue Jan 27, 2020 · 1 comment
Assignees
@nofun97

Comments

@nofun97
Copy link
Member

nofun97 commented Jan 27, 2020

Have an API that will let users configure their logger.

Part of #5
@nofun97 nofun97 self-assigned this Jan 27, 2020
@nofun97 nofun97 mentioned this issue Jan 28, 2020
Merged
@nofun97
Copy link
Member Author

nofun97 commented Jan 30, 2020 •
edited
Loading

Needs:

  1. Output configurator
  2. Codelinker config
  3. Level configurator
  4. Color (low priority)

anzopensource pushed a commit that referenced this issue Feb 15, 2021
@anzdaddy
TimeTravel.After won't change offset till after channel read (#6)
0a73cd6 
Also replace Jump... methods with NewTimeTravelStartingAt.
anzopensource pushed a commit that referenced this issue Feb 15, 2021
@ChloePlanet @juliaogris
@cuminandpaprika @orlade-anz @anzdaddy
rebase anz-bank/master (#7)
ed62b3a 
* health: Create OpenAPI spec for default health endpoints

Add swagger spec to describe default health package endpoints in
standardised format:

	/readyz
	/healthz
	/version

Issue: #52

* github: Fix version bump action label

Update version bump action label from "build" (the GitHub action's job)
to something more meaningful and easier to identify in branch protection
settings.

* Jack/pkg update (#71)

* Add downstream test job to workflow (#1)

* Contextual clock package (#2)

* Context-driven envvar package (#3)

* Jack/speed up GitHub mod (#4)

Speeds up the module package when in Github mode by ~50%

Changes
- Fix bug in caching, which was causing cached files to not be found
- Run Github API calls concurrently, rather than synchronously
- Add benchmark tests

* Run in parallel

name                           old time/op  new time/op  delta
GetCacheRef-16                  696ms ± 0%   505ms ± 0%   ~     (p=1.000 n=1+1)
RetrieveGitHubModeUncached-16   1.65s ± 0%   1.05s ± 0%   ~     (p=1.000 n=1+1)

* Fix bug in cache dir

Previously the cache dir was getting added twice as the mod.dir already contains the cache directory.
Therefore, none of the cached files were found and were being re-downloaded every time

* Add benchmark test and `make bench`

* Receive cache ref with channels

* Move integration tests under integration build tag (#5)

Moves integration tests into separate files so that they don't get run in CI. This speeds up the `make test` command significantly
Integration tests can be run with the `make integration` target


Co-authored-by: Oliver <[email protected]>
Co-authored-by: Marcelo Cantos <[email protected]>

* health: Fix data race in health readiness access

Make the readiness value a uint32 and read/write it with the `atomic`
package functions `LoadUint32` and `StoreUint32`, instead of unprotected
access to a boolean.

The health readiness value is read and written from different goroutines
mostly. This was explicitly done without locking as the readiness value
was a single bit and nothing that needed to be synchronised. That's
still bad. At least, it should be an atomic - no data should be
read/written concurrently without an atomic or a mutex or more.

Add a test case that fails the race detector if readiness is not
properly protected.

* TimeTravel.After won't change offset till after channel read (#6)

Also replace Jump... methods with NewTimeTravelStartingAt.

Co-authored-by: Julia Ogris <[email protected]>
Co-authored-by: Jack Zheng <[email protected]>
Co-authored-by: Oliver <[email protected]>
Co-authored-by: Marcelo Cantos <[email protected]>
Co-authored-by: Cam Hutchison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nofun97 nofun97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nofun97