-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run because of failure to create output directory #251
Comments
Hi there! I will take a look today and let you know |
Got a similar bug when developing locally PS C:\Users\pedro\OneDrive\Escritorio\shortest> pnpm shortest:dev --headless
> @ shortest:dev C:\Users\pedro\OneDrive\Escritorio\shortest
> npx tsx packages/shortest/src/cli/bin.ts "--headless"
📄 C:\Users\pedro\OneDrive\Escritorio\shortest\google.test.ts
X [ERROR] Failed to create output directory: mkdir C:\Users\pedro\AppData\Local\Temp\shortest-cache\C:: The filename, directory name, or volume label syntax is incorrect.
X [ERROR] Failed to create output directory: mkdir C:\Users\pedro\AppData\Local\Temp\shortest-cache\C:: The filename, directory name, or volume label syntax is incorrect.
Test Execution Error: Build failed with 2 errors:
error: Failed to create output directory: mkdir C:\Users\pedro\AppData\Local\Temp\shortest-cache\C:: The filename, directory name, or volume label syntax is incorrect.
error: Failed to create output directory: mkdir C:\Users\pedro\AppData\Local\Temp\shortest-cache\C:: The filename, directory name, or volume label syntax is incorrect.
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Tests 0 passed (0)
Duration 0.47s
Start at 17:01:21
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ |
Probably obvious but may as well leave it here. It only happens on windows, I ran the same command on a linux devcontainer and worked fine. From my debugging, it seem to be related to the TestCompiler class, so maybe worth taking a look |
Cannot really test this one as I am not a windows user. However, I can help you with troubleshooting:
let me know if any of this helps |
Thanks, will try and let you know.
…On Sat, 4 Jan, 2025, 7:31 am gladysh, ***@***.***> wrote:
Cannot really test this one as I am not a windows user.
However, I can help you with troubleshooting:
1. looking at temp path, I see two abnormalities: 'C::' at then end of
the path and the fact that disc is always C
2. apparently the problem is this line of code
<https://github.com/anti-work/shortest/blob/main/packages/shortest/src/core/compiler/index.ts#L42>
3. path.join is a platform independent way to concatenate paths. The
drive letter on the other hand is windows only
4. apparently, tmpdir gets tmp dir from you computer ENV, verify it's
set up correctly
5. try to delete the folder if it's present, hard code the line with
correct path and run it again
let me know if any of this helps
—
Reply to this email directly, view it on GitHub
<#251 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADU47NGFOXIWIMYBDTGUMET2I46JHAVCNFSM6AAAAABURYUWYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZQGAYDEOJSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Im also getting the same issue running on windows. anyone been able to resolve? thanks |
I'll work on a fix. I have a windows machine, and I think a good chunk of users would be trying this library in a windows machine, it should be bug free. |
great! If you need any help with this, reach out. we can also have a call |
A call would be great actually! |
@PedroAVJ Looks like this is fixed but not merged. Is there any way I can get the fix and try it out? |
You can run pnpm pack to build the tgz bundle and use that when running pnpm install. We can setup a quick discord call if you want |
Please merge the PR. |
@patelmayankce have you had a chance to try out the changes on your end as well? It would be great to test in a another Windows environment before merging. |
I'm trying to run shortest test from my folder in D:, however if fails to start with the following error. Where do I set a custom output directory? or should I be running it from C: only?
The text was updated successfully, but these errors were encountered: