Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gset preparation without the use of amt-tools library #1

Open
anthonio9 opened this issue Dec 21, 2023 · 1 comment
Open

Gset preparation without the use of amt-tools library #1

anthonio9 opened this issue Dec 21, 2023 · 1 comment
Assignees

Comments

@anthonio9
Copy link
Owner

amt-tools library is a dependency coming from the world of FRETNET, however getting rid of it would greatly increase the my understanding of the code and decrease the dependency list.

amt-tools is only responsible for reading the pitch labels from the GuitarSet dataset, then filling the blanks with zeros. That's about it. The not very comfortable feature of the GuitarSet is how it uses jams to store the data, think about it!

@anthonio9 anthonio9 self-assigned this Dec 21, 2023
@anthonio9
Copy link
Owner Author

amt-tools library is now only used in tests as a reference. It seems that the new approach works fine. When working on this issue I've found out that the warning

/home/antoni/Documents/Aalto/ThesisWork/Source/EvaluationOfResearchPapers/penn/penn/data/preprocess/core.py:274: RuntimeWarning: divide by zero encountered in log2
  pitch = 2. ** np.interp(new_times, times, np.log2(pitch))

comes from the fact that some strings are completely empty and are filled with 0s, should that be fixed somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant