Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create autoresponder for docs PRs #69

Closed
samccann opened this issue Jul 10, 2023 · 6 comments
Closed

Create autoresponder for docs PRs #69

samccann opened this issue Jul 10, 2023 · 6 comments

Comments

@samccann
Copy link
Contributor

ansibot posted a comment for every docs PR opened. Would be great if we could incorporate that here as well:

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our ansible/community#678 - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@gotmax23
Copy link
Collaborator

I wonder if there's a better place we can put that text. The comments tended to create spam in my opinion. That said, we could use a Github Action for this if you didn't have something else in mind.

@gundalow
Copy link
Contributor

Bonus points if we can find some tool that only adds this if they've not got any commits in the repo?
Or maybe we just call it out at the top of README.md in the root of the repo

@gotmax23
Copy link
Collaborator

Bonus points if we can find some tool that only adds this if they've not got any commits in the repo?

This information is available via the API, so yes, it should be possible. I can try to put together a PR if we decide this is wanted.

@gundalow
Copy link
Contributor

Bonus points if we can find some tool that only adds this if they've not got any commits in the repo?

This information is available via the API, so yes, it should be possible. I can try to put together a PR if we decide this is wanted.

Nice
Please don't spend any time on this yet though, lets wait to see if others thing it's helpful. Maybe updating README.md is good enough

@webknjaz
Copy link
Member

Bonus points if we can find some tool that only adds this if they've not got any commits in the repo?

https://probot.github.io/apps/welcome/

@samccann
Copy link
Contributor Author

we added it recently (within the past year) to ansible/ansible repo specifically so we could draw people who added prs etc into our community. I agree it's noise for anyone but new contributors. I'd be reluctant to just leave it in the readme as that seems a step backward in terms of growing our community.

gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jul 25, 2023
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jul 25, 2023
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jul 25, 2023
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jul 25, 2023
gotmax23 added a commit that referenced this issue Jul 25, 2023
* Add Github Action to label issues and PRs (#118)

* labeler: welcome new contributors

Fixes: #69

* labeler: improve logging

* labeler: add --authed-dry-run flag

Some data such as author_association is only available to authenticated API
users. This helps with testing.

* ci labeler: fix `Print event information` step (#166)

* labeler: fix log() type annotations (#165)

print() coerces any object to a str.
gotmax23 added a commit that referenced this issue Jul 25, 2023
* Add Github Action to label issues and PRs (#118)

* labeler: welcome new contributors

Fixes: #69

* labeler: improve logging

* labeler: add --authed-dry-run flag

Some data such as author_association is only available to authenticated API
users. This helps with testing.

* ci labeler: fix `Print event information` step (#166)

* labeler: fix log() type annotations (#165)

print() coerces any object to a str.
gotmax23 added a commit that referenced this issue Jul 25, 2023
* Add Github Action to label issues and PRs (#118)

* labeler: welcome new contributors

Fixes: #69

* labeler: improve logging

* labeler: add --authed-dry-run flag

Some data such as author_association is only available to authenticated API
users. This helps with testing.

* ci labeler: fix `Print event information` step (#166)

* labeler: fix log() type annotations (#165)

print() coerces any object to a str.
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Dec 31, 2023
As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Dec 31, 2023
As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Dec 31, 2023
As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jan 7, 2024
As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204
gotmax23 added a commit that referenced this issue Jan 10, 2024
* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of #69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: #204

* pr_labeler: address potential race condition
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Sep 17, 2024
* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Sep 18, 2024
* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Sep 18, 2024
* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Sep 18, 2024
* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of ansible#69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: ansible#204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)
oraNod pushed a commit that referenced this issue Sep 20, 2024
* pr_labeler: improve create_boilerplate_comment logging

(cherry picked from commit 5730ba9)

* pr_labeler: add --force-process-closed flag

(cherry picked from commit 44ffe0f)

* pr_labeler: add warning for porting_guides changes

This adds a warning message when PRs are created that edit
porting_guides by someone outside of the Release Management WG. These
files are automatically generated during the ansible release process and
should not be modified.

Fixes: #503
(cherry picked from commit d2e6625)

* pr_labeler: use @release-management-wg team for porting_guide check

Instead of hardcoding the list of release managers, we can use the
Github API to retrieve the members of the
`@ansible/release-management-wg` team.

(cherry picked from commit dddfd7e)

* pr_labeler: exempt bots from porting_guide check

For example, patchback is not a release manager, but we still want it to
backport Porting Guide PRs.

(cherry picked from commit 746662c)

* pr_labeler: improve porting_guide_changes template wording

Co-authored-by: Sandra McCann <[email protected]>
(cherry picked from commit 95ece7e)

* pr_labeler: refactor new_contributor_welcome code (#990)

* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of #69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: #204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)

* Bump actions/setup-python from 4 to 5 (#966)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

(cherry picked from commit 466b1fd)

* pr_labeler: re-architect triager script (#1882)

This commit reorganizes the issue/PR triager script and updates the
workflow to run more efficiently.

- Make the script a proper Python package instead of an unwieldy single
  file
- Use locked dependencies and UV to decrease workflow runtime to under
  10 seconds.

(cherry picked from commit 7138e42)
(cherry picked from commit 1cf9f79)

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oraNod pushed a commit that referenced this issue Sep 20, 2024
* pr_labeler: improve create_boilerplate_comment logging

(cherry picked from commit 5730ba9)

* pr_labeler: add --force-process-closed flag

(cherry picked from commit 44ffe0f)

* pr_labeler: add warning for porting_guides changes

This adds a warning message when PRs are created that edit
porting_guides by someone outside of the Release Management WG. These
files are automatically generated during the ansible release process and
should not be modified.

Fixes: #503
(cherry picked from commit d2e6625)

* pr_labeler: use @release-management-wg team for porting_guide check

Instead of hardcoding the list of release managers, we can use the
Github API to retrieve the members of the
`@ansible/release-management-wg` team.

(cherry picked from commit dddfd7e)

* pr_labeler: exempt bots from porting_guide check

For example, patchback is not a release manager, but we still want it to
backport Porting Guide PRs.

(cherry picked from commit 746662c)

* pr_labeler: improve porting_guide_changes template wording

Co-authored-by: Sandra McCann <[email protected]>
(cherry picked from commit 95ece7e)

* pr_labeler: refactor new_contributor_welcome code (#990)

* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of #69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: #204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)

* Bump actions/setup-python from 4 to 5 (#966)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

(cherry picked from commit 466b1fd)

* pr_labeler: re-architect triager script (#1882)

This commit reorganizes the issue/PR triager script and updates the
workflow to run more efficiently.

- Make the script a proper Python package instead of an unwieldy single
  file
- Use locked dependencies and UV to decrease workflow runtime to under
  10 seconds.

(cherry picked from commit 7138e42)
(cherry picked from commit 1cf9f79)

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oraNod pushed a commit that referenced this issue Sep 20, 2024
* pr_labeler: improve create_boilerplate_comment logging

(cherry picked from commit 5730ba9)

* pr_labeler: add --force-process-closed flag

(cherry picked from commit 44ffe0f)

* pr_labeler: add warning for porting_guides changes

This adds a warning message when PRs are created that edit
porting_guides by someone outside of the Release Management WG. These
files are automatically generated during the ansible release process and
should not be modified.

Fixes: #503
(cherry picked from commit d2e6625)

* pr_labeler: use @release-management-wg team for porting_guide check

Instead of hardcoding the list of release managers, we can use the
Github API to retrieve the members of the
`@ansible/release-management-wg` team.

(cherry picked from commit dddfd7e)

* pr_labeler: exempt bots from porting_guide check

For example, patchback is not a release manager, but we still want it to
backport Porting Guide PRs.

(cherry picked from commit 746662c)

* pr_labeler: improve porting_guide_changes template wording

Co-authored-by: Sandra McCann <[email protected]>
(cherry picked from commit 95ece7e)

* pr_labeler: refactor new_contributor_welcome code (#990)

* pr_labeler: add GlobalArgs.full_repo property

* pr_labeler: refactor new_contributor_welcome code

As of #69, the
pr_labeler responds with a welcome message when an issue or PR is opened
by a new contributor. It turns out this never actually worked properly.

The previous method that relied on Github's `author_association` flag
did not work with the app token that the pr_labeler uses. This refactors
the code to figure out whether a user is a new contributor by
searching the list of issues and PRs.

Fixes: #204

* pr_labeler: address potential race condition

(cherry picked from commit 763815d)

* Bump actions/setup-python from 4 to 5 (#966)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

(cherry picked from commit 466b1fd)

* pr_labeler: re-architect triager script (#1882)

This commit reorganizes the issue/PR triager script and updates the
workflow to run more efficiently.

- Make the script a proper Python package instead of an unwieldy single
  file
- Use locked dependencies and UV to decrease workflow runtime to under
  10 seconds.

(cherry picked from commit 7138e42)
(cherry picked from commit 1cf9f79)

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants