Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Remove deprecated GalaxyClient contrstuctor default arguments #121

Closed
gotmax23 opened this issue Dec 1, 2023 · 3 comments · Fixed by #131
Closed

[v3] Remove deprecated GalaxyClient contrstuctor default arguments #121

gotmax23 opened this issue Dec 1, 2023 · 3 comments · Fixed by #131

Comments

@gotmax23
Copy link
Collaborator

gotmax23 commented Dec 1, 2023

No description provided.

@gotmax23 gotmax23 added this to the antsibull-core v3 milestone Dec 1, 2023
@felixfontein
Copy link
Collaborator

Hmm, these arguments haven't been deprecated yet.

@felixfontein
Copy link
Collaborator

I guess we can still remove them. We don't promise deprecations before removals (even for collections included in Ansible we suggest they do it, but don't enforce it), and the only two known users of antsibull-core don't need this anymore. This is a new major release, so let's just remove it anyway.

@felixfontein
Copy link
Collaborator

I've implemented this in #131. Some of this functionality is currently still used in antsibull-docs and antsibull, I've created PRs to make them stop using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants