Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the module name in the Example block #44

Closed
sky-joker opened this issue May 11, 2020 · 6 comments · Fixed by #89
Closed

About the module name in the Example block #44

sky-joker opened this issue May 11, 2020 · 6 comments · Fixed by #89
Assignees
Labels
documentation Improvements or additions to documentation module The issue or pull request is related to Zabbix module

Comments

@sky-joker
Copy link
Contributor

SUMMARY

The module name of the example block of existing modules is not FQCN.
I think I should change the module name to FQCN.

For example, before

- name: Get Zabbix template as JSON
  zabbix_template_info:
(snip)

after

- name: Get Zabbix template as JSON
  community.zabbix.zabbix_template_info:
(snip)
ISSUE TYPE
  • Documentation Report
COMPONENT NAME
ANSIBLE VERSION

@sky-joker sky-joker added the documentation Improvements or additions to documentation label May 11, 2020
@D3DeFi
Copy link
Contributor

D3DeFi commented May 11, 2020

I'd say it is better to first address issue mentioned in this comment and do it all at once if we are to decide that modules and roles should loose zabbix[-_] prefixes.

@ericsysmin
Copy link
Contributor

I am working on that as all of this causes molecule to fail. @D3DeFi

@D3DeFi
Copy link
Contributor

D3DeFi commented Jun 6, 2020

@ericsysmin just to clarify, do you plan to implement this change for plugins/modules too or do you have only roles/ in mind? I believe that @sky-joker addressed only modules with this issue.

@D3DeFi D3DeFi added the module The issue or pull request is related to Zabbix module label Jun 6, 2020
@sky-joker
Copy link
Contributor Author

I believe that @sky-joker addressed only modules with this issue.

That’s right :)
When I created this issue, I was only considering modules.

@D3DeFi
Copy link
Contributor

D3DeFi commented Jun 10, 2020

@sky-joker as role names have been decided (zabbix_role), we are not gonna rename modules. This issue can now be addressed - can you please work on it?

I agree that all examples should use FQCN.

@sky-joker
Copy link
Contributor Author

I understand.
I’ll create PR that it change the module name in EXAMPLE of all modules to FQCN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation module The issue or pull request is related to Zabbix module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants