From 81fd56eff3cb9a61959d78c6942d7def21e6a56c Mon Sep 17 00:00:00 2001 From: Rohit Thakur Date: Fri, 1 Dec 2023 12:47:37 +0530 Subject: [PATCH] [Major] Prepare release 5.0.0 (#220) * [Major] Prepare release 5.0.0 Signed-off-by: rohitthakur2590 * add ansible-lint file Signed-off-by: rohitthakur2590 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update CHANGELOG.rst Co-authored-by: Nilashish Chakraborty * Update changelogs/changelog.yaml --------- Signed-off-by: rohitthakur2590 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nilashish Chakraborty --- .ansible-lint | 5 +++++ .github/workflows/lint.yml | 13 +++++++++++++ .github/workflows/tests.yml | 4 ---- CHANGELOG.rst | 13 +++++++++++++ README.md | 2 +- changelogs/changelog.yaml | 11 +++++++++++ changelogs/fragments/lint_fixtures.yaml | 3 --- galaxy.yml | 4 ++-- meta/runtime.yml | 2 +- tests/config.yml | 3 +++ 10 files changed, 49 insertions(+), 11 deletions(-) create mode 100644 .ansible-lint create mode 100644 .github/workflows/lint.yml delete mode 100644 changelogs/fragments/lint_fixtures.yaml create mode 100644 tests/config.yml diff --git a/.ansible-lint b/.ansible-lint new file mode 100644 index 00000000..8d9bb70b --- /dev/null +++ b/.ansible-lint @@ -0,0 +1,5 @@ +--- +profile: production + +exclude_paths: + - changelogs/changelog.yaml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 00000000..fbac38cb --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,13 @@ +--- +name: ansible-lint +on: # yamllint disable-line rule:truthy + pull_request: + branches: ["main"] +jobs: + build: + name: Ansible Lint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Run ansible-lint + uses: ansible/ansible-lint@main diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 21f8ea56..506c33aa 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,8 +13,6 @@ on: # yamllint disable-line rule:truthy - cron: '0 0 * * *' jobs: - ansible-lint: - uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main changelog: uses: ansible-network/github_actions/.github/workflows/changelog.yml@main if: github.event_name == 'pull_request' @@ -31,7 +29,6 @@ jobs: all_green: if: ${{ always() }} needs: - - ansible-lint - changelog - sanity - unit-galaxy @@ -41,7 +38,6 @@ jobs: - run: >- python -c "assert 'failure' not in set([ - '${{ needs.ansible-lint.result }}', '${{ needs.changelog.result }}', '${{ needs.sanity.result }}', '${{ needs.unit-galaxy.result }}', diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 39bdff83..e5da703b 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,19 @@ Cisco Asa Collection Release Notes .. contents:: Topics +v5.0.0 +====== + +Release Summary +--------------- + +Starting from this release, the minimum `ansible-core` version this collection requires is `2.14.0`. The last known version compatible with ansible-core<2.14 is `v4.0.3`. + +Major Changes +------------- + +- Bumping `requires_ansible` to `>=2.14.0`, since previous ansible-core versions are EoL now. + v4.0.3 ====== diff --git a/README.md b/README.md index 7d846945..6402ce0f 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ The Ansible Cisco ASA collection includes a variety of Ansible content to help a ## Ansible version compatibility -This collection has been tested against following Ansible versions: **>=2.9.10**. +This collection has been tested against following Ansible versions: **>=2.14.0**. For collections that support Ansible 2.9, please ensure you update your `network_os` to use the fully qualified collection name (for example, `cisco.ios.ios`). diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index d0f0d4e3..6726f770 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -204,3 +204,14 @@ releases: - codecov_pr.yml - lint_fixtures.yaml release_date: "2023-10-31" + 5.0.0: + changes: + major_changes: + - Bumping `requires_ansible` to `>=2.14.0`, since previous ansible-core versions + are EoL now. + release_summary: + Starting from this release, the minimum `ansible-core` version + this collection requires is `2.14.0`. The last known version compatible with + fragments: + - lint_fixtures.yaml + release_date: "2023-11-30" diff --git a/changelogs/fragments/lint_fixtures.yaml b/changelogs/fragments/lint_fixtures.yaml deleted file mode 100644 index ed913ff8..00000000 --- a/changelogs/fragments/lint_fixtures.yaml +++ /dev/null @@ -1,3 +0,0 @@ ---- -trivial: - - Fix ansible lint errors and update docs. diff --git a/galaxy.yml b/galaxy.yml index 45e9ce59..f1f14bda 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -2,7 +2,7 @@ authors: - Ansible Security Community (ansible-security) dependencies: - "ansible.netcommon": ">=2.5.1" + "ansible.netcommon": ">=6.0.0" license_file: LICENSE name: asa namespace: cisco @@ -13,4 +13,4 @@ issues: https://github.com/ansible-collections/cisco.asa/issues tags: [cisco, asa, networking, security] # NOTE(pabelanger): We create an empty version key to keep ansible-galaxy # happy. We dynamically inject version info based on git information. -version: 4.0.3 +version: 5.0.0 diff --git a/meta/runtime.yml b/meta/runtime.yml index 35f1e5f9..150efb6d 100644 --- a/meta/runtime.yml +++ b/meta/runtime.yml @@ -1,5 +1,5 @@ --- -requires_ansible: ">=2.9.10" +requires_ansible: ">=2.14.0" plugin_routing: action: asa_acls: diff --git a/tests/config.yml b/tests/config.yml new file mode 100644 index 00000000..c26ea596 --- /dev/null +++ b/tests/config.yml @@ -0,0 +1,3 @@ +--- +modules: + python_requires: ">=3.9"