Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Toggle whiteboard" control icon & label do not match #18027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: "Toggle whiteboard" control icon & label do not match #18027

wants to merge 1 commit into from
+30 −4

Conversation

snowtimeglass
Copy link
Contributor

Purpose / Description

"Toggle whiteboard" control icon does not match the label and the actual action.

Fixes

Approach

  • For the "Toggle whiteboard" item in Controls settings page, replace the current "Hide whiteboard" icon with "Enable whiteboard" icon
  • Add a new control item for "Show/Hide whiteboard"

How Has This Been Tested?

Checked on physical device (Android 11)

"Toggle whiteboard" behavior

Record_2025-02-26-10-49-34_7b5228b5a93c00ecba98ecb0735c59e2.mp4

"Show/Hide whiteboard" behavior

Record_2025-02-26-12-01-23_7b5228b5a93c00ecba98ecb0735c59e2.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@snowtimeglass
fix: whiteboard control icon & label do not match
ba17024 
- For the "Toggle whiteboard" label in Controls settings page, replace the current "Show/Hide whiteboard" icon with "Enable whiteboard" icon
- Add a new control item for "Show/Hide whiteboard"
@github-actions GitHub Actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

BrayanDSO
BrayanDSO requested changes Feb 28, 2025
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to fix something, only do that in the PR.

Any kind of new features like the new control preference should be sugggested first in the forums so people can discuss it

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Feb 28, 2025
@Amit-kumar80844
Copy link

is this issue solved ?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrayanDSO BrayanDSO BrayanDSO requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs Author Reply Waiting for a reply from the original author Strings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Toggle whiteboard" control icon & label do not match
3 participants
@snowtimeglass @Amit-kumar80844 @BrayanDSO