Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Media does not detect/delete trashed media files properly #17993

Open
3 of 4 tasks
KurisuAndo opened this issue Feb 17, 2025 · 3 comments
Open
3 of 4 tasks

Check Media does not detect/delete trashed media files properly #17993

KurisuAndo opened this issue Feb 17, 2025 · 3 comments
Assignees
Labels
2.19 Accepted Maintainers welcome a PR implementing this feature Anki Ecosystem Compatibility

Comments

@KurisuAndo
Copy link

KurisuAndo commented Feb 17, 2025

Checked for duplicates?

  • This issue is not a duplicate

Does it also happen in the desktop version?

  • This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

  1. Delete some cards with media files on the desktop app.
  2. Use Check Media twice to delete unused files and clear the trash folder, then sync.
  3. Open AnkiDroid, sync, then Check Media (it will display "No unused or missing files found").
  4. Open the media.trash folder on the AnkiDroid folder to see the (supposedly) deleted file(s) there.

Expected behaviour

Media files that have been completely deleted on the desktop version should not be put into the trash folder of the Android version. Even if it is the expected behavior, Check Media should still be able to detect these files on the trash folder (but it does not).

Debug info

AnkiDroid Version = 2.20.1 (e32a82c33646807ea19623c9c88be38965bc07e6)
Backend Version = 0.1.48-anki24.11 (24.11 c47638ca36f99dd4f3b81ae82d964aec66e392e0)
Android Version = 11 (SDK 30)
ProductFlavor = full
Manufacturer = samsung
Model = SM-A507FN
Hardware = exynos9611
Webview User Agent = Mozilla/5.0 (Linux; Android 11; SM-A507FN Build/RP1A.200720.012; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/132.0.6834.163 Mobile Safari/537.36
ACRA UUID = 3987c06b-3562-44fd-b990-08c8d9750f3e
FSRS = 1.4.3 (Enabled: true)
Crash Reports Enabled = true

(Optional) Anything else you want to share?

Something weird also happens when I try to delete unused media using the Check Media feature on AnkiDroid. The files are deleted without being sent to the media trash folder, however when synced, the file is kept in the trash folder of the desktop version (but not on the android trash folder). It works the way I expect it to on the desktop version, it is just on this app that I can observe this behavior.

Research

  • I have checked the manual and the FAQ and could not find a solution to my issue
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
Copy link

welcome bot commented Feb 17, 2025

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@david-allison david-allison added Accepted Maintainers welcome a PR implementing this feature 2.19 and removed Needs Triage labels Feb 17, 2025
@david-allison
Copy link
Member

@criticalAY did we add this in your recent change?

@criticalAY
Copy link
Contributor

No but there is a TODO already I can take it up after view model migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.19 Accepted Maintainers welcome a PR implementing this feature Anki Ecosystem Compatibility
Projects
None yet
Development

No branches or pull requests

3 participants