Purpose / Description

Auto Advance does not work when both "Don't play audio automatically" and "Wait for audio" are enabled

• Auto Advance does not work when both "Don't play audio automatically" and "Wait for audio" are enabled #17937

Fixes

• Fixes Auto Advance does not work when both "Don't play audio automatically" and "Wait for audio" are enabled #17937

Approach

TheFile Abstractflashcardviewer.k contain automaticAnswerShouldWaitForAudio() function
https://github.com/ankidroid/Anki-Android/blob/main/AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.kt#L1309-L1312
this function only checks "Wait for audio" but ignores autoplay, which means Auto Advance might still wait even if autoplay is disabled.Since this function doesn’t check autoplay, we need to fix it so Auto Advance behaves correctly.

suspend fun automaticAnswerShouldWaitForAudio(): Boolean = withCol {
    val card = currentCard ?: return@withCol false  // Prevents null crash
    val waitForAudio = decks.configDictForDeckId(card.did).waitForAudio
    val soundConfig = CardSoundConfig.create(this, card)  // Fetch autoplay setting

    return@withCol waitForAudio && soundConfig.autoplay  //  Only wait if autoplay is enabled
}

Since ReviewerViewModel.kt does not inherit from AbstractFlashcardViewer.kt, we need a reference to an instance of AbstractFlashcardViewer.then call the function through flashcardViewer

suspend fun shouldWaitForAudio(): Boolean {
    return flashcardViewer?.automaticAnswerShouldWaitForAudio() ?: false
}

then Modify AutoAdvance.kt so it correctly calls shouldWaitForAudio() from ReviewerViewModel.kt

suspend fun shouldWaitForAudio(): Boolean {
    return viewModel.shouldWaitForAudio()  
}

How Has This Been Tested?

Instructions to reprodruce
1-(Optional) Confirm that "Auto Advance" feature is working in the selected deck in Reviewer
2-Long-press the deck in the main screen > "Deck options" >
"Audio" > set "Don't play audio automatically" enabled
(It is set to disabled by default)
3-"Auto Advance" > set "Wait for audio" enabled
(It is already set to enabled by default)
4-Tap "Save"
5-Tap the deck to open Reviewer
verfication:AutoAdvance behaves correctly

tested on android device samsung

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner