Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Database configuration as an export environment variable. #88

Closed
6 tasks
codesankalp opened this issue Feb 16, 2021 · 13 comments · Fixed by #133
Closed
6 tasks

Get Database configuration as an export environment variable. #88

codesankalp opened this issue Feb 16, 2021 · 13 comments · Fixed by #133
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Maintenance Repository maintenance.

Comments

@codesankalp
Copy link
Member

Description

As a contributor,
I need database configuration to be exported as separate environment variables
so that changing database configuration for deployed as well as the local project does not depend on changing code every time.

Acceptance Criteria

Update [Required]

  • Get DB_NAME, DB_USERNAME, DB_PASSWORD, DB_HOST, DB_PORT from machine environments.
  • Document these environment variables on README with the appropriate value for setting up the project.
  • Raise value error if env variables are not exported or found.
  • Write at least one unit-test to test it.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 hour

@codesankalp
Copy link
Member Author

@isabelcosta Can you please add labels to it?

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance. labels Feb 16, 2021
@NenadPantelic
Copy link

@isabelcosta Can I work on it?

@Amulya-coder
Copy link
Member

@NenadPantelic you are already assigned to #60.

@NenadPantelic
Copy link

@Amulya-coder Oh sorry, I totally overlooked that, I don't know how 🤦

@ashwinijha6
Copy link
Contributor

Hey @isabelcosta could you pls assign me this issue I would like to work on this

@codesankalp
Copy link
Member Author

As @ashwinijha6 You are already assigned to an issue, I am assigning this to @NeerajSati.
@NeerajSati Assigning you!!

@codesankalp codesankalp removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 6, 2021
@devkapilbansal devkapilbansal added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 9, 2021
@codesankalp
Copy link
Member Author

@ashwinijha6 Assigning this to you. 🚀

@isabelcosta
Copy link
Member

@ashwinijha6 are you still interested in this issue? I will unassign due to almost one month's of inactivity. Let me know if you interested, and we can assign again.

@ashwinijha6
Copy link
Contributor

@ashwinijha6 are you still interested in this issue? I will unassign due to almost one month's of inactivity. Let me know if you interested, and we can assign again.

I'm so sorry for the delay @isabelcosta. I'm a bit busy at the moment you can unassign me & make it available for others.

@isabelcosta
Copy link
Member

No problem at all @ashwinijha6 :) Good luck with your other commitments 🙏🏾 you're always welcome to come and contribute 🤗

@ashwinijha6
Copy link
Contributor

No problem at all @ashwinijha6 :) Good luck with your other commitments 🙏🏾 you're always welcome to come and contribute 🤗

Thankyou for understanding @isabelcosta. I'll surely be back once I finish up my work ❤️

@codesankalp
Copy link
Member Author

As #109 PR is almost complete I can work on this. What do you think @isabelcosta?

@isabelcosta
Copy link
Member

Yes @codesankalp I think this could be useful to contributors to get this solved.

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 2, 2021
codesankalp added a commit to codesankalp/anitab-forms-backend that referenced this issue Apr 5, 2021
added env variables for db config and updated readme.

Fixes anitab-org#88
isabelcosta pushed a commit that referenced this issue Apr 9, 2021
added env variables for db config and updated readme
Fixes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Maintenance Repository maintenance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants